From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anuradha Karuppiah Subject: Re: [RFC PATCH net-next v3 3/4] rocker: Handle IFF_PROTODOWN by doing a PHYS-DOWN on the switch port. Date: Tue, 28 Apr 2015 13:35:46 -0700 Message-ID: References: <1430156304-13187-4-git-send-email-anuradhak@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "David S. Miller" , Netdev , Roopa Prabhu , Andy Gospodarek , Wilson Kok To: Scott Feldman Return-path: Received: from mail-la0-f48.google.com ([209.85.215.48]:35988 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966013AbbD1Ufs (ORCPT ); Tue, 28 Apr 2015 16:35:48 -0400 Received: by lagv1 with SMTP id v1so5228129lag.3 for ; Tue, 28 Apr 2015 13:35:47 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Apr 28, 2015 at 12:48 PM, Scott Feldman wrote: > On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah > wrote: >> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote: >>> On Mon, Apr 27, 2015 at 10:38 AM, wrote: >>>> From: Anuradha Karuppiah >>>> >>>> IFF_PROTODOWN can be set by user space applications like MLAG on detecting >>>> errors on a switch port. This patch provides sample switch driver changes >>>> for handling IFF_PROTODOWN. Rocker PHYS disables the port in response to >>>> protodown. >>>> >>>> Note: I understand Scott has some rocker changes on hold. I will re-spin >>>> this patch once his changes are in. >>>> >>>> Signed-off-by: Anuradha Karuppiah >>>> Signed-off-by: Andy Gospodarek >>>> Signed-off-by: Roopa Prabhu >>>> Signed-off-by: Wilson Kok >>>> --- >>>> drivers/net/ethernet/rocker/rocker.c | 16 +++++++++++++++- >>>> 1 file changed, 15 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c >>>> index a87b177..e3084e3 100644 >>>> --- a/drivers/net/ethernet/rocker/rocker.c >>>> +++ b/drivers/net/ethernet/rocker/rocker.c >>>> @@ -3838,7 +3838,8 @@ static int rocker_port_open(struct net_device *dev) >>>> >>>> napi_enable(&rocker_port->napi_tx); >>>> napi_enable(&rocker_port->napi_rx); >>>> - rocker_port_set_enable(rocker_port, true); >>>> + if (!(dev->flags & IFF_PROTO_DOWN)) >>>> + rocker_port_set_enable(rocker_port, true); >>>> netif_start_queue(dev); >>>> return 0; >>>> >>>> @@ -4238,6 +4239,18 @@ static int rocker_port_swdev_port_stp_update(struct net_device *dev, u8 state) >>>> return rocker_port_stp_update(rocker_port, state); >>>> } >>>> >>>> +static int rocker_port_swdev_port_phy_state_set(struct net_device *dev, >>>> + bool enable) >>>> +{ >>>> + struct rocker_port *rocker_port = netdev_priv(dev); >>>> + >>>> + if (enable && (dev->flags & IFF_UP) && !(dev->flags & IFF_PROTO_DOWN)) >>>> + rocker_port_set_enable(rocker_port, true); >>>> + else >>>> + rocker_port_set_enable(rocker_port, false); >>> >>> This isn't working like your expecting. PHY link is still up on the >>> rocker port, so the other end of the wire still sees link UP even when >>> IFF_PROTO_DOWN is set locally. >> >> I wanted to check with you first on the rocker handling; that is the main >> reason for posting this an RFC (thanks for the review). >> >> I used rocker_port_set_enable/PORT_PHYS_ENABLE for setting the phy state >> because I assumed that in the case of an offloaded switch driver it would be >> the equivalent of doing "sdk port N en=1|0". Is that not the case? If not, >> could you please point me in the right direction? > > To put PHY link down, on PORT_PHYS_ENABLE true, rocker device (qemu) > would need to down the link state for the port so other end of wire > sees link down. I think I remember looking into that but didn't > implement it. In qemu monitor, you can manually set the link up/down > (set_link [on|off]). We'd need to call the same from within the > rocker device. > > So if we want to be able to test this with rocker, we'll need a device > and driver change. Thanks for the details, Scott. We will looking into implementing the necessary changes to get it working with rocker.