From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE601C43381 for ; Sat, 16 Feb 2019 02:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93175222D0 for ; Sat, 16 Feb 2019 02:22:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kgriOVBl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390273AbfBPCWO (ORCPT ); Fri, 15 Feb 2019 21:22:14 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:42726 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbfBPCWN (ORCPT ); Fri, 15 Feb 2019 21:22:13 -0500 Received: by mail-ot1-f68.google.com with SMTP id i5so19808333oto.9 for ; Fri, 15 Feb 2019 18:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tYaJmX+LrXjeXbEa/zmEH5DdzXjBV9NlkSk/XZa26/I=; b=kgriOVBlQnylEv0pCFnOAt2LHFe2fNHmY0Ah5bTfUUNPdFBR0GW7IkKSVMQy7FFQ9L UerFpFXOR0Z2sTJu88lvIgewY/uYID2stvOTi3Me03ZQJtwBsTI1xVCUIv4UrSsMT/ii 5lOMgvjP9IUdjLeTJcOiB6MBkUzuhtvgnof/aUPmsX0cXKe0rokNuwhyj3oqFkfH3bg4 E2aEEB4F6t7BPGf8gLPVBStcSGCOIegIhneU8mfjnsjIhA3NOs2umm0AjyHDoc3xUmhI lBEZRVR8++ekYwSOnmHJgzV9apz3I+mo7RbF4DMZn0Yy6tlN+AC3f55HawuFjZCo0Xka AJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tYaJmX+LrXjeXbEa/zmEH5DdzXjBV9NlkSk/XZa26/I=; b=FJGV+J23iZRk/WBQLnniXIg8NDdWyl05T/QUkbtjgamvKnfo7Fe2tcFm0sJQOLSjvx akk9iWdKe+qtY7F47hBl3vYuo47iYsLOFX2/LkkF+e5h9vNKfhhvUiFcNlexwOlw24hg 2GvmQzy2q48lvRNsDeHfF21DvPucEMbvA5RQ64u+wzPCgoYv89DX7DbjAJg/yW8+vcEO TcxfckVk8iZyS+C3h90bmfGTTi/IUrRBh3o4x8gVa2gsh7Il3npDeH9QnCBpu+G0Ezf4 FV9IozDmXCSrYL67vKyVLBuHasKq2vfDbIIWNcZmPOImmlnSn3JGaY10yn0jwzclcpgB VRHA== X-Gm-Message-State: AHQUAuY/a1VSXkR0A+5oJz16EPu9Fhxqm//KV53lpzvR848LTMHaS4QB IOq8EaJR4icoBXzi/3BNYezRfHmwkrnUh8moN2kwMw== X-Google-Smtp-Source: AHgI3IZ1EEnim5SLg7YrezMPO7Z33v9/Uf1H7sWyIdkR9KWeuBUurI3rmfuZge2m3ku+meMAsZmSPxuMC2MUtDIaU7Y= X-Received: by 2002:a05:6830:1543:: with SMTP id l3mr7916235otp.84.1550283732723; Fri, 15 Feb 2019 18:22:12 -0800 (PST) MIME-Version: 1.0 References: <20190215213621.183537-1-edumazet@google.com> <20190215213621.183537-2-edumazet@google.com> In-Reply-To: <20190215213621.183537-2-edumazet@google.com> From: Neal Cardwell Date: Fri, 15 Feb 2019 21:21:56 -0500 Message-ID: Subject: Re: [PATCH net 1/2] tcp: clear icsk_backoff in tcp_write_queue_purge() To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Yuchung Cheng , soukjin bae Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet wrote: > > soukjin bae reported a crash in tcp_v4_err() handling > ICMP_DEST_UNREACH after tcp_write_queue_head(sk) > returned a NULL pointer. > > Current logic should have prevented this : > > if (seq != tp->snd_una || !icsk->icsk_retransmits || > !icsk->icsk_backoff || fastopen) > break; > > Problem is the write queue might have been purged > and icsk_backoff has not been cleared. > > Signed-off-by: Eric Dumazet > Reported-by: soukjin bae > --- > net/ipv4/tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Neal Cardwell Thanks! neal