From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B147C43381 for ; Sat, 16 Feb 2019 02:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C75B0222D0 for ; Sat, 16 Feb 2019 02:21:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vjsA46+H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390116AbfBPCVv (ORCPT ); Fri, 15 Feb 2019 21:21:51 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:34607 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbfBPCVu (ORCPT ); Fri, 15 Feb 2019 21:21:50 -0500 Received: by mail-ot1-f65.google.com with SMTP id 98so19923563oty.1 for ; Fri, 15 Feb 2019 18:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yay4bZ9EOBDlwSjEluW7/jbX9Ms4vPhgIa7xA1K7dfo=; b=vjsA46+HgS6M5Z+ekRuJ2O6E1lJzeOK/QT2NerROWGhaIryGX3ySnoyUFaI+ck82db N8iWutYGRtX5zrEV+NCNAmyup7vSO2r0HKkpMLJGewsHwEfhBzOGBK7OnqJvNFWT/re3 hP0BQejCCiSUo9WJPAXbkgonM7Cpu8ZQV2Pvwfzah14GUsT5lPmKR6n1dHx7Dxcz2hRw D28MCACYXlj8ndYY+JNHNDBuBX8U/fvpaTD+FRecdyWZIub/A5I8B9GvHXpgoG5N8ByS uvmRgZkdPMw/5/JOmiQAxSV6KBAMwFuIcixG599OcJKzgmtDpd9f/OL8zKiyZWFFjGxR pzpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yay4bZ9EOBDlwSjEluW7/jbX9Ms4vPhgIa7xA1K7dfo=; b=gsDjGlLRzP4NTEhK1XfqwDcl+7fu2Jr4jvvum7h8euluurjq5lcBCx5SVnu23QbLyz 7Sq6jsx5oc9GxQ/ZP3vqGpfTCWV+Z2zByN9UwAzAkjaiVWJZ68EQ8x6Rqs9o/6+BNbR/ z/7vQnqJ951AGj7Hn1+uWxvz+cooDDOdusoM1aOw4Dp0NpUeDMKr/x7kb320ulogQKgj 90oVZyrWDe/Xlz8VVxaxlNf5XeuVm4u59Q7TpqFjFIp1RtSbI+PUWJd3H3wRbLKkikQn ZE0J9X2pVEHJmUB8rczKkR9AT80OYnF6oyOlnpK7GA1CbObs5Fo3ZAFjKk7kUP9db7Hc RSww== X-Gm-Message-State: AHQUAuZ6jeAcSPnfdwBAJh1Tm9VFagUI0msQGf/IYlZ+YoZs4G7Bzrs+ fPlwLLnUbgpFVuMbEJJk2S3EhpyA0j59go10jKDQYS5u7CeMRQ== X-Google-Smtp-Source: AHgI3IYkynn9o8Jy4Stqrj8TTStSWQ7LQ8EOcdnL+zLisAXlwIr4IVyprum1KXbuiPCIw56aUJtkkWNCTpJ1wjhclzM= X-Received: by 2002:a9d:3426:: with SMTP id v35mr8461865otb.71.1550283709560; Fri, 15 Feb 2019 18:21:49 -0800 (PST) MIME-Version: 1.0 References: <20190215213621.183537-1-edumazet@google.com> <20190215213621.183537-3-edumazet@google.com> In-Reply-To: <20190215213621.183537-3-edumazet@google.com> From: Neal Cardwell Date: Fri, 15 Feb 2019 21:21:32 -0500 Message-ID: Subject: Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Yuchung Cheng , soukjin bae Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet wrote: > > ICMP handlers are not very often stressed, we should > make them more resilient to bugs that might surface in > the future. > > If there is no packet in retransmit queue, we should > avoid a NULL deref. > > Signed-off-by: Eric Dumazet > Reported-by: soukjin bae > --- > net/ipv4/tcp_ipv4.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Acked-by: Neal Cardwell Thanks! neal