netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neal Cardwell <ncardwell@google.com>
To: Yuchung Cheng <ycheng@google.com>
Cc: David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Nandita Dukkipati <nanditad@google.com>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4 net-next] tcp: consolidate SYNACK RTT sampling
Date: Sun, 21 Jul 2013 22:45:13 -0400	[thread overview]
Message-ID: <CADVnQynNtha0Vc=oG=qiH94tAmWuQHjMcU-DFNudQdV_53+jeA@mail.gmail.com> (raw)
In-Reply-To: <1374385170-358-1-git-send-email-ycheng@google.com>

On Sun, Jul 21, 2013 at 1:39 AM, Yuchung Cheng <ycheng@google.com> wrote:
> This patch series improve RTT sampling in three ways:
> 1. Sample RTT during fast recovery and reordering events.
> 2. Favor ack-based RTT to timestamps because of broken TS ECR fields
> 3. Consolidate the RTT measurement logic.
>
> The first patch consolidates SYNACK and other RTT measurement to use a
> central function tcp_ack_update_rtt(). A (small) bonus is now SYNACK
> RTT measurement happens after PAWS check, potentially reducing the
> impact of RTO seeding on bad TCP timestamps values.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>

The idea seems very nice to me, but I think a line or two got dropped
in a rebase. :-)

In the previous version of this patch you moved the TFO-specific call
to tcp_synack_rtt_meas() out to a spot in tcp_rcv_state_process()
where both TFO and non-TFO passive connections would hit it. In this
version of the patch it removes the existing calls to
tcp_synack_rtt_meas() but does not add this new call to replace them.
(And it does not seem to be added back in a later patch in the
series.)

Other than that, looks great.

neal

      parent reply	other threads:[~2013-07-22  2:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21  5:39 Yuchung Cheng
2013-07-21  5:39 ` [PATCH 2/4 net-next] tcp: prefer packet timing to TS-ECR for RTT Yuchung Cheng
2013-07-22  3:17   ` Neal Cardwell
2013-07-21  5:39 ` [PATCH 3/4 net-next] tcp: measure RTT from new SACK Yuchung Cheng
2013-07-22  3:32   ` Neal Cardwell
2013-07-21  5:39 ` [PATCH 4/4 net-next] tcp: use RTT from SACK for RTO Yuchung Cheng
2013-07-22  3:40   ` Neal Cardwell
2013-07-22  2:45 ` Neal Cardwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADVnQynNtha0Vc=oG=qiH94tAmWuQHjMcU-DFNudQdV_53+jeA@mail.gmail.com' \
    --to=ncardwell@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=nanditad@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    --subject='Re: [PATCH 1/4 net-next] tcp: consolidate SYNACK RTT sampling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).