From: Anders Roxell <anders.roxell@linaro.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, "Björn Töpel" <bjorn@rivosinc.com>,
"Lina Wang" <lina.wang@mediatek.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: Add cross-compilation support for BPF programs
Date: Tue, 22 Nov 2022 08:47:01 +0100 [thread overview]
Message-ID: <CADYN=9JDOBHEgmiWCy_k5sXLizdtRET6-G5_PdZcaOLvSp5vTA@mail.gmail.com> (raw)
In-Reply-To: <87edtwb6e8.fsf@all.your.base.are.belong.to.us>
On Mon, 21 Nov 2022 at 17:48, Björn Töpel <bjorn@kernel.org> wrote:
>
> Anders Roxell <anders.roxell@linaro.org> writes:
>
> > On Sat, 19 Nov 2022 at 18:19, Björn Töpel <bjorn@kernel.org> wrote:
> [...]
> >> Now that BPF builds are starting to show up in more places
> >> (selftests/net, and soon selftests/hid), maybe it would be cleaner to
> >> move parts of the BPF builds to lib.mk?
> >
> > Yes, since its in tc-testing too.
> > Maybe thats what we should do already now?
>
> Ok, so there's three BPF builds, in addition to selftests/bpf. Do you
> suggest moving (cross-compiled) libbpf builds (for bpf_helpers_defs.h
> generation) and some kind of clang BPF build-rule to lib.mk?
Maybe start with moving the libbpf builds, for build_helpers_defs.h generation,
and 'define get_sys_includes' into the lib.mk ?
> Or would
> you like more things there, like resolve_btfids?
>
> I guess this patch could go in regardless, and fix the build *now*, and
> do a lib.mk thing as a follow-up?
Make sense.
Reviewed-by: Anders Roxell <anders.roxell@linaro.org>
Cheers,
Anders
next prev parent reply other threads:[~2022-11-22 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 17:18 [PATCH net-next] selftests: net: Add cross-compilation support for BPF programs Björn Töpel
2022-11-21 10:45 ` Anders Roxell
2022-11-21 16:48 ` Björn Töpel
2022-11-22 7:47 ` Anders Roxell [this message]
2022-11-22 12:54 ` Paolo Abeni
2022-11-22 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9JDOBHEgmiWCy_k5sXLizdtRET6-G5_PdZcaOLvSp5vTA@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=bjorn@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lina.wang@mediatek.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).