Netdev Archive on lore.kernel.org
 help / Atom feed
From: Alban Crequy <alban@kinvolk.io>
To: Quentin Monnet <quentin.monnet@netronome.com>
Cc: "Alban Crequy" <alban.crequy@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Iago López Galeiras" <iago@kinvolk.io>
Subject: Re: [PATCH] bpf: bpftool, fix documentation for attach types
Date: Tue, 19 Feb 2019 14:48:24 +0100
Message-ID: <CADZs7q70CEUwgsiJQWmTBFict3ocyGDTU=mR+spMawcfhVr92Q@mail.gmail.com> (raw)
In-Reply-To: <208650eb-37bf-228b-43f8-de5027747db9@netronome.com>

On Mon, Feb 11, 2019 at 2:26 PM Quentin Monnet
<quentin.monnet@netronome.com> wrote:
>
> 2019-02-11 13:54 UTC+0100 ~ Alban Crequy <alban.crequy@gmail.com>
> > From: Alban Crequy <alban@kinvolk.io>
> >
> > bpftool has support for attach types "stream_verdict" and
> > "stream_parser" but the documentation was referring to them with
> > "skb_verdict" and "skb_parse". The inconsistency comes from commit
> > b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to
> > maps").
> >
> > This patch changes the documentation to match the implementation.
> >
> > Signed-off-by: Alban Crequy <alban@kinvolk.io>
> > ---
> >  tools/bpf/bpftool/prog.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> > index 0640e9bc0ada..dfaa019a60f0 100644
> > --- a/tools/bpf/bpftool/prog.c
> > +++ b/tools/bpf/bpftool/prog.c
> > @@ -1198,7 +1198,7 @@ static int do_help(int argc, char **argv)
> >               "                 cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n"
> >               "                 cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n"
> >               "                 cgroup/sendmsg4 | cgroup/sendmsg6 }\n"
> > -             "       ATTACH_TYPE := { msg_verdict | skb_verdict | skb_parse |\n"
> > +             "       ATTACH_TYPE := { msg_verdict | stream_verdict | stream_parser |\n"
> >               "                        flow_dissector }\n"
> >               "       " HELP_SPEC_OPTIONS "\n"
> >               "",
> >
>
> Thanks Alban!
>
> Could you please fix the man page and the bash completion file at the
> same time?

Yes, I will do that soon. Sorry for the delay in replying.

Thanks,
Alban

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 12:54 Alban Crequy
2019-02-11 13:26 ` Quentin Monnet
2019-02-19 13:48   ` Alban Crequy [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADZs7q70CEUwgsiJQWmTBFict3ocyGDTU=mR+spMawcfhVr92Q@mail.gmail.com' \
    --to=alban@kinvolk.io \
    --cc=alban.crequy@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=iago@kinvolk.io \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quentin.monnet@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox