From: Xin Long <lucien.xin@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
network dev <netdev@vger.kernel.org>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [PATCHv3 iproute2-next 3/7] iproute_lwtunnel: add options support for erspan metadata
Date: Thu, 23 Apr 2020 19:06:11 +0800 [thread overview]
Message-ID: <CADvbK_d-DR2GiptuC1tPqzw6zTDzcf340E_GN+DyhACMRQ_g=A@mail.gmail.com> (raw)
In-Reply-To: <edcf3540-da91-d7af-12ff-8ca7d708bd3a@gmail.com>
Hi, Stephen,
any update?
This is your last reply:
"""
1. The parse and print functions should have the same formats.
I.e. if you take the output and do a little massaging of the ifindex
it should be accepted as an input set of parameters.
2. As much as possible, the JSON and non-JSON output should be similar.
If non-JSON prints in hex, then JSON should display hex and vice/versa.
"""
Do you still hope to change things like that (just note it won't be
consistent with:)
6217917a tc: m_tunnel_key: Add tunnel option support to act_tunnel_key
56155d4d tc: f_flower: add geneve option match support to flower
or go with the current set? I'm now okay to do either of them.
Thanks.
On Mon, Apr 20, 2020 at 6:28 AM David Ahern <dsahern@gmail.com> wrote:
>
> On 4/19/20 2:39 AM, Xin Long wrote:
> > This patchset is in "deferred" status for a long time.
> > What should we do about this one?
> > should I improve something then repost or the lastest one will be fine.
>
> I am fine with this set as is; Stephen had some concerns.
next prev parent reply other threads:[~2020-04-23 11:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 10:30 [PATCHv3 iproute2-next 0/7] iproute2: fully support for geneve/vxlan/erspan options Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 1/7] iproute_lwtunnel: add options support for geneve metadata Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 2/7] iproute_lwtunnel: add options support for vxlan metadata Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 3/7] iproute_lwtunnel: add options support for erspan metadata Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 4/7] tc: m_tunnel_key: add options support for vxlan Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 5/7] tc: m_tunnel_key: add options support for erpsan Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 6/7] tc: f_flower: add options support for vxlan Xin Long
2020-02-14 10:30 ` [PATCHv3 iproute2-next 7/7] tc: f_flower: add options support for erspan Xin Long
2020-02-14 16:13 ` [PATCHv3 iproute2-next 3/7] iproute_lwtunnel: add options support for erspan metadata Stephen Hemminger
2020-02-14 17:40 ` Xin Long
2020-02-15 0:21 ` Stephen Hemminger
2020-02-15 4:18 ` Xin Long
2020-02-15 16:51 ` David Ahern
2020-02-16 6:38 ` Xin Long
2020-02-17 19:53 ` David Ahern
2020-02-17 21:02 ` Stephen Hemminger
2020-02-18 4:29 ` Xin Long
2020-04-19 8:39 ` Xin Long
2020-04-19 22:28 ` David Ahern
2020-04-23 11:06 ` Xin Long [this message]
2020-04-26 18:29 ` David Ahern
2020-04-27 5:51 ` Xin Long
2020-04-23 15:23 ` Stephen Hemminger
2020-04-23 18:03 ` Jakub Kicinski
2020-04-27 12:38 ` David Ahern
2020-04-27 23:07 ` Stephen Hemminger
2020-04-28 7:22 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvbK_d-DR2GiptuC1tPqzw6zTDzcf340E_GN+DyhACMRQ_g=A@mail.gmail.com' \
--to=lucien.xin@gmail.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).