From: Xin Long <lucien.xin@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
LiLiang <liali@redhat.com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
jianghaoran <jianghaoran@kylinos.cn>,
Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [PATCH net] ipv6: prevent only DAD and RS sending for IFF_NO_ADDRCONF
Date: Sun, 8 Jan 2023 11:58:08 -0500 [thread overview]
Message-ID: <CADvbK_eCRoH2JqKV=8J2Yuj_yC3ueFz4je8VhXOgerQ_rhtB2A@mail.gmail.com> (raw)
In-Reply-To: <7ab910df-c864-7f11-0c1a-acb863dd1539@kernel.org>
On Sat, Jan 7, 2023 at 9:04 PM David Ahern <dsahern@kernel.org> wrote:
>
> On 1/6/23 9:51 AM, Xin Long wrote:
> > Currently IFF_NO_ADDRCONF is used to prevent all ipv6 addrconf for the
> > slave ports of team, bonding and failover devices and it means no ipv6
> > packets can be sent out through these slave ports. However, for team
> > device, "nsna_ping" link_watch requires ipv6 addrconf. Otherwise, the
> > link will be marked failure.
> >
> > The orginal issue fixed by IFF_NO_ADDRCONF was caused by DAD and RS
> > packets sent by slave ports in commit c2edacf80e15 ("bonding / ipv6: no
> > addrconf for slaves separately from master") where it's using IFF_SLAVE
> > and later changed to IFF_NO_ADDRCONF in commit 8a321cf7becc ("net: add
> > IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf").
>
> That patch is less than a month old, and you are making changes again.
Hi, David,
That patch will not change anything, and it's an improvement. the
problem is the commit:
0aa64df30b38 ("net: team: use IFF_NO_ADDRCONF flag to prevent ipv6 addrconf")
So it affects the team driver only, and I should've done more team driver tests.
Sorry for having to touch the IPv6 code for this problem in the team driver.
>
> I think you should add some test cases that cover the permutations you
> want along with any possible alternative / negative use cases.
IFF_NO_ADDRCONF are used by team/bonding/failover, I will try to add
a kselftest for this with team/bonding.
Thanks for the suggestion.
next prev parent reply other threads:[~2023-01-08 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 16:51 [PATCH net] ipv6: prevent only DAD and RS sending for IFF_NO_ADDRCONF Xin Long
2023-01-08 2:04 ` David Ahern
2023-01-08 16:58 ` Xin Long [this message]
2023-01-10 8:59 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvbK_eCRoH2JqKV=8J2Yuj_yC3ueFz4je8VhXOgerQ_rhtB2A@mail.gmail.com' \
--to=lucien.xin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fubar@us.ibm.com \
--cc=jianghaoran@kylinos.cn \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).