From: Xin Long <lucien.xin@gmail.com>
To: "Leppanen, Jere (Nokia - FI/Espoo)" <jere.leppanen@nokia.com>
Cc: network dev <netdev@vger.kernel.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"michael.tuexen@lurchi.franken.de"
<michael.tuexen@lurchi.franken.de>
Subject: Re: [PATCH net] sctp: return a one-to-one type socket when doing peeloff
Date: Wed, 4 Mar 2020 17:38:24 +0800 [thread overview]
Message-ID: <CADvbK_ewk7mGNr6T4smWeQ0TcW3q4yabKZwGX3dK=XcH7gv=KQ@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0702MB3610BB291019DD7F51DBC906ECE40@HE1PR0702MB3610.eurprd07.prod.outlook.com>
On Wed, Mar 4, 2020 at 2:38 AM Leppanen, Jere (Nokia - FI/Espoo)
<jere.leppanen@nokia.com> wrote:
>
> On Mon, 2 Mar 2020, Xin Long wrote:
>
> > As it says in rfc6458#section-9.2:
> >
> > The application uses the sctp_peeloff() call to branch off an
> > association into a separate socket. (Note that the semantics are
> > somewhat changed from the traditional one-to-one style accept()
> > call.) Note also that the new socket is a one-to-one style socket.
> > Thus, it will be confined to operations allowed for a one-to-one
> > style socket.
> >
> > Prior to this patch, sctp_peeloff() returned a one-to-many type socket,
> > on which some operations are not allowed, like shutdown, as Jere
> > reported.
> >
> > This patch is to change it to return a one-to-one type socket instead.
>
> Thanks for looking into this. I like the patch, and it fixes my simple
> test case.
>
> But with this patch, peeled-off sockets are created by copying from a
> one-to-many socket to a one-to-one socket. Are you sure that that's
> not going to cause any problems? Is it possible that there was a
> reason why peeloff wasn't implemented this way in the first place?
I'm not sure, it's been there since very beginning, and I couldn't find
any changelog about it.
I guess it was trying to differentiate peeled-off socket from TCP style
sockets.
>
> With this patch there's no way to create UDP_HIGH_BANDWIDTH style
> sockets anymore, so the remaining references should probably be
> cleaned up:
>
> ./net/sctp/socket.c:1886: if (!sctp_style(sk, UDP_HIGH_BANDWIDTH) && msg->msg_name) {
> ./net/sctp/socket.c:8522: if (sctp_style(sk, UDP_HIGH_BANDWIDTH))
> ./include/net/sctp/structs.h:144: SCTP_SOCKET_UDP_HIGH_BANDWIDTH,
>
> This patch disables those checks. The first one ignores a destination
> address given to sendmsg() with a peeled-off socket - I don't know
> why. The second one prevents listen() on a peeled-off socket.
My understanding is:
UDP_HIGH_BANDWIDTH is another kind of one-to-one socket, like TCP style.
it can get asoc by its socket when sending msg, doesn't need daddr.
Now I thinking to fix your issue in sctp_shutdown():
@@ -5163,7 +5163,7 @@ static void sctp_shutdown(struct sock *sk, int how)
struct net *net = sock_net(sk);
struct sctp_endpoint *ep;
- if (!sctp_style(sk, TCP))
+ if (sctp_style(sk, UDP))
return;
in this way, we actually think:
one-to-many socket: UDP style socket
one-to-one socket includes: UDP_HIGH_BANDWIDTH and TCP style sockets.
next prev parent reply other threads:[~2020-03-04 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 6:57 [PATCH net] sctp: return a one-to-one type socket when doing peeloff Xin Long
2020-03-03 18:38 ` Leppanen, Jere (Nokia - FI/Espoo)
2020-03-04 9:38 ` Xin Long [this message]
2020-03-04 17:13 ` Jere Leppanen
2020-03-05 14:01 ` David Laight
2020-03-05 17:31 ` Jere Leppanen
2020-03-11 3:34 ` Marcelo Ricardo Leitner
2020-03-11 18:41 ` Jere Leppanen
2020-03-10 1:09 ` David Miller
2020-03-11 3:35 ` Marcelo Ricardo Leitner
2020-03-13 0:27 ` [sctp] 38ec705901: ltp.test_peeloff.fail kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADvbK_ewk7mGNr6T4smWeQ0TcW3q4yabKZwGX3dK=XcH7gv=KQ@mail.gmail.com' \
--to=lucien.xin@gmail.com \
--cc=davem@davemloft.net \
--cc=jere.leppanen@nokia.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=michael.tuexen@lurchi.franken.de \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).