From: "Daniel T. Lee" <danieltimlee@gmail.com>
To: "Toke Høiland-Jørgensen" <thoiland@redhat.com>
Cc: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Andrii Nakryiko" <andriin@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] samples: bpf: fix outdated README build command
Date: Tue, 12 Nov 2019 20:47:10 +0900 [thread overview]
Message-ID: <CAEKGpzg_yijpW6+jm8q8Xj-RR97fbGotBKOMocP7AfxmgU9gqQ@mail.gmail.com> (raw)
In-Reply-To: <87bltircil.fsf@toke.dk>
On Mon, Nov 11, 2019 at 6:24 PM Toke Høiland-Jørgensen
<thoiland@redhat.com> wrote:
>
> Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
>
> > On Sun, Nov 10, 2019 at 12:19 AM Daniel T. Lee <danieltimlee@gmail.com> wrote:
> >>
> >> Currently, building the bpf samples under samples/bpf directory isn't
> >> working. Running make from the directory 'samples/bpf' will just shows
> >> following result without compiling any samples.
> >>
> >
> > Do you mind trying to see if it's possible to detect that plain `make`
> > is being run from samples/bpf subdirectory, and if that's the case,
> > just running something like `make M=samples/bpf -C ../../`? If that's
> > not too hard, it would be a nice touch to still have it working old
> > (and intuitive) way, IMO.
>
> I think it's just the M= that's missing. Tentatively, the below seems to
> work for me (I get some other compile errors, but I think that is
> unrelated).
>
> -Toke
>
>
Thanks for the review!
Modifying the Makefile seems better solution!
Again, It's just the issue has been solved as Daniel Borkmann mentioned.
Thanks for the review!
Best,
Daniel
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 8a9af3ab7769..48e7f1ff7861 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -246,7 +246,7 @@ endif
>
> # Trick to allow make to be run from this directory
> all:
> - $(MAKE) -C ../../ $(CURDIR)/ BPF_SAMPLES_PATH=$(CURDIR)
> + $(MAKE) -C ../../ M=$(CURDIR) BPF_SAMPLES_PATH=$(CURDIR)
>
> clean:
> $(MAKE) -C ../../ M=$(CURDIR) clean
>
next prev parent reply other threads:[~2019-11-12 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 8:19 [PATCH] samples: bpf: fix outdated README build command Daniel T. Lee
2019-11-11 6:09 ` Andrii Nakryiko
2019-11-11 9:24 ` Toke Høiland-Jørgensen
2019-11-12 11:47 ` Daniel T. Lee [this message]
2019-11-12 11:45 ` Daniel T. Lee
2019-11-11 13:58 ` Daniel Borkmann
2019-11-12 11:48 ` Daniel T. Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEKGpzg_yijpW6+jm8q8Xj-RR97fbGotBKOMocP7AfxmgU9gqQ@mail.gmail.com \
--to=danieltimlee@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=thoiland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).