From: "Daniel T. Lee" <danieltimlee@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH,bpf-next v2 2/2] samples: bpf: update map definition to new syntax BTF-defined map
Date: Thu, 7 Nov 2019 13:44:48 +0900 [thread overview]
Message-ID: <CAEKGpzi5qz14TWm4ZSmk8zWcw_z2f9iM+dW10Tu6evJg60aa_g@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZpBqPAKy1fKUQYSm3Wxez29EuBYqu_n2SayCfDt_ziUg@mail.gmail.com>
On Thu, Nov 7, 2019 at 11:53 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Wed, Nov 6, 2019 at 4:52 PM Daniel T. Lee <danieltimlee@gmail.com> wrote:
> >
> > Since, the new syntax of BTF-defined map has been introduced,
> > the syntax for using maps under samples directory are mixed up.
> > For example, some are already using the new syntax, and some are using
> > existing syntax by calling them as 'legacy'.
> >
> > As stated at commit abd29c931459 ("libbpf: allow specifying map
> > definitions using BTF"), the BTF-defined map has more compatablility
> > with extending supported map definition features.
> >
> > The commit doesn't replace all of the map to new BTF-defined map,
> > because some of the samples still use bpf_load instead of libbpf, which
> > can't properly create BTF-defined map.
> >
> > This will only updates the samples which uses libbpf API for loading bpf
> > program. (ex. bpf_prog_load_xattr)
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
> > ---
> > Changes in v2:
> > - stick to __type() instead of __uint({key,value}_size) where possible
> >
> > samples/bpf/sockex1_kern.c | 12 ++--
> > samples/bpf/sockex2_kern.c | 12 ++--
> > samples/bpf/xdp1_kern.c | 12 ++--
> > samples/bpf/xdp2_kern.c | 12 ++--
> > samples/bpf/xdp_adjust_tail_kern.c | 12 ++--
> > samples/bpf/xdp_fwd_kern.c | 13 ++--
> > samples/bpf/xdp_redirect_cpu_kern.c | 108 ++++++++++++++--------------
> > samples/bpf/xdp_redirect_kern.c | 24 +++----
> > samples/bpf/xdp_redirect_map_kern.c | 24 +++----
> > samples/bpf/xdp_router_ipv4_kern.c | 64 ++++++++---------
> > samples/bpf/xdp_rxq_info_kern.c | 37 +++++-----
> > samples/bpf/xdp_tx_iptunnel_kern.c | 26 +++----
> > 12 files changed, 178 insertions(+), 178 deletions(-)
>
> Heh, 1-to-1 insertions/deletions, no excuse to use old syntax ;)
>
> Thanks for completing conversion!
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
> [...]
Thank you for your time and effort for the review.
Thanks,
Daniel
next prev parent reply other threads:[~2019-11-07 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 0:51 [PATCH,bpf-next v2 0/2] samples: bpf: update map definition to new syntax BTF-defined map Daniel T. Lee
2019-11-07 0:51 ` [PATCH,bpf-next v2 1/2] samples: bpf: update outdated error message Daniel T. Lee
2019-11-07 0:51 ` [PATCH,bpf-next v2 2/2] samples: bpf: update map definition to new syntax BTF-defined map Daniel T. Lee
2019-11-07 2:53 ` Andrii Nakryiko
2019-11-07 4:44 ` Daniel T. Lee [this message]
2019-11-09 3:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEKGpzi5qz14TWm4ZSmk8zWcw_z2f9iM+dW10Tu6evJg60aa_g@mail.gmail.com \
--to=danieltimlee@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).