netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Erich E. Hoover" <ehoover@mines.edu>
To: Shawn Lu <shawn.lu@ericsson.com>
Cc: Linux Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] Implement IP_UNICAST_IF socket option.
Date: Tue, 7 Feb 2012 18:10:05 -0700	[thread overview]
Message-ID: <CAEU2+vrfMXXr1S0BYtN07uwXfK8T8A_ob3PR3RoHOdqdFv0YEg@mail.gmail.com> (raw)
In-Reply-To: <62162DF05402B341B3DB59932A1FA992B5B5D1FC8A@EUSAACMS0702.eamcs.ericsson.se>

On Tue, Feb 7, 2012 at 5:23 PM, Shawn Lu <shawn.lu@ericsson.com> wrote:
>> ...
>> +             ifindex = (__force int)ntohl((__force __be32)val);
> We always use ifindex as host byte order, why the val  is passed in as
> network byte order and then convert it
> Back to host byte order. Anything special about it?

Yes, the value for IP_UNICAST_IF is passed in network byte order in
implementations on other operating systems.  David Miller requested
that this option by passed in the same way as that of other systems.

Erich Hoover
ehoover@mines.edu

       reply	other threads:[~2012-02-08  1:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <62162DF05402B341B3DB59932A1FA992B5B5D1FC8A@EUSAACMS0702.eamcs.ericsson.se>
2012-02-08  1:10 ` Erich E. Hoover [this message]
2012-02-08  6:25   ` Shawn Lu
2012-02-07 21:44 Erich E. Hoover
2012-02-08  7:21 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEU2+vrfMXXr1S0BYtN07uwXfK8T8A_ob3PR3RoHOdqdFv0YEg@mail.gmail.com \
    --to=ehoover@mines.edu \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.lu@ericsson.com \
    --subject='Re: [PATCH v6 1/2] Implement IP_UNICAST_IF socket option.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).