From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EEAC04AB5 for ; Mon, 3 Jun 2019 12:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D28E1253BF for ; Mon, 3 Jun 2019 12:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="PYGUZK+G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727366AbfFCM2y (ORCPT ); Mon, 3 Jun 2019 08:28:54 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:39713 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfFCM2y (ORCPT ); Mon, 3 Jun 2019 08:28:54 -0400 Received: by mail-lj1-f196.google.com with SMTP id a10so12755414ljf.6 for ; Mon, 03 Jun 2019 05:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WvqHOC4rVKX462WwE0yHSlmBZF1YO9aROqbvN/HfH6Y=; b=PYGUZK+GV8eTc/sc1/LJV2/FRh6sJ3eQVXqtHpM1WdCHjxWxGcJHVX6no/5nw7UnO6 DV0yDj/ec3TxqyDkkmaBhVAS4R0g44dxp9/lCrwxqbNfRaWzZra8qYmAc+YZXjsgn2FX UGutllvZNq/hEvDPh7uqahFLrpIWsFBdileHo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WvqHOC4rVKX462WwE0yHSlmBZF1YO9aROqbvN/HfH6Y=; b=NOWJ3iM2ISsBUvTn/rSOaxm38CKHDw8dYz9MPkFil6vWOgMHlOOqkff73za6IwCED/ JeN33UUqdrAqMYKqzrRjVEC0o5gaC2yGEsr7kjTpKxg6Z4KIur331b4e7yXjSSNy144j UZGvKO5GWCWeK7k2scGTRSCCP9GBgfFGijgR7xowftEH2WCqR0KfS1eMMBCgYd0sFBaX jRSWKsb6Ttv4GLAmuhpWcDafkr6Fo8UxYRjXTomJu1SIaN1oMRdJ/txJBRiyuXEMONU1 TsBPKI/1qTmUm+wyxmAbGH/B5iRz5vvaT2ztau0Gq9uPXpTxxlpDS+E0jb2HpgspGkY4 P8xA== X-Gm-Message-State: APjAAAWgxdU3r+EAf5SCnCZs6H8iFfNcWIFOnjJ72xo/gyZqQkInhvb/ RwsPywaMs2n2KLdGqu8l+A+EYzyLkSrMHkGGz+TaCA== X-Google-Smtp-Source: APXvYqzHzzga29JITONK+bAJt2s0MgC0PRTzbGVoOX6cnbI/p9OIDGMPiEXt3Q9ji63k1yr8CtUni9paU765sGDmFMs= X-Received: by 2002:a2e:9742:: with SMTP id f2mr13977662ljj.184.1559564932484; Mon, 03 Jun 2019 05:28:52 -0700 (PDT) MIME-Version: 1.0 References: <20190601222738.6856-1-joel@joelfernandes.org> <20190601222738.6856-3-joel@joelfernandes.org> <20190602070014.GA543@amd> <20190603064212.GA7400@amd> In-Reply-To: <20190603064212.GA7400@amd> From: Joel Fernandes Date: Mon, 3 Jun 2019 08:28:41 -0400 Message-ID: Subject: Re: [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry To: Pavel Machek Cc: LKML , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Josh Triplett , Kees Cook , Kernel Hardening , Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Linux PM , Mathieu Desnoyers , Neil Brown , netdev , Oleg Nesterov , "Paul E. McKenney" , Peter Zilstra , "Rafael J. Wysocki" , rcu , Steven Rostedt , Tejun Heo , Thomas Gleixner , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 3, 2019 at 2:42 AM Pavel Machek wrote: > > On Sun 2019-06-02 08:24:35, Joel Fernandes wrote: > > On Sun, Jun 2, 2019 at 8:20 AM Joel Fernandes wrote: > > > > > > On Sun, Jun 2, 2019 at 3:00 AM Pavel Machek wrote: > > > > > > > > On Sat 2019-06-01 18:27:34, Joel Fernandes (Google) wrote: > > > > > Signed-off-by: Joel Fernandes (Google) > > > > > > > > This really needs to be merged to previous patch, you can't break > > > > compilation in middle of series... > > > > > > > > Or probably you need hlist_for_each_entry_rcu_lockdep() macro with > > > > additional argument, and switch users to it. > > > > > > Good point. I can also just add a temporary transition macro, and then > > > remove it in the last patch. That way no new macro is needed. > > > > Actually, no. There is no compilation break so I did not follow what > > you mean. The fourth argument to the hlist_for_each_entry_rcu is > > optional. The only thing that happens is new lockdep warnings will > > arise which later parts of the series fix by passing in that fourth > > argument. > > Sorry, I missed that subtlety. Might be worth it enabling the lockdep > warning last in the series... Good idea, will do! Thanks.