linux-next: Signed-off-by missing for commit in the net-next tree

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi all,

Commit

  aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Yifeng Sun]

Hi Stephen,

My apologies, thanks for the email. Please add the signed-off if you can.

Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>

Thanks,
Yifeng

On Tue, Aug 6, 2019 at 4:30 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Commit
>
>   aa733660dbd8 ("openvswitch: Print error when ovs_execute_actions() fails")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi Yifeng,

On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun <pkusunyifeng@gmail.com> wrote:
>
> My apologies, thanks for the email. Please add the signed-off if you can.

Dave does not rebase his trees, so that is not possible.  Just remember
for next time, thanks :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Yifeng Sun]

Hi Stephen,

Sure, thanks!
Yifeng

On Tue, Aug 6, 2019 at 6:54 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Yifeng,
>
> On Tue, 6 Aug 2019 16:37:26 -0700 Yifeng Sun <pkusunyifeng@gmail.com> wrote:
> >
> > My apologies, thanks for the email. Please add the signed-off if you can.
>
> Dave does not rebase his trees, so that is not possible.  Just remember
> for next time, thanks :-)
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hi all,

Commit

  9c33663af9ad ("Bluetooth: hci_ldisc: check HCI_UART_PROTO_READY flag in HCIUARTGETPROTO")

is missing a Signed-off-by from its author.

Actually I assume that the SOB and the Author Email metadata are just
using two different email addresses.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi all,

Commit

  1fc4fa2ac93d ("rxrpc: Fix congestion management")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hi all,

Commits

  aa36c94853b2 ("net/mlx5: Set SMFS as a default steering mode if device supports it")
  4ff725e1d4ad ("net/mlx5: DR, Ignore modify TTL if device doesn't support it")
  cc2295cd54e4 ("net/mlx5: DR, Improve steering for empty or RX/TX-only matchers")
  f59464e257bd ("net/mlx5: DR, Add support for matching on geneve_tlv_option_0_exist field")
  09753babaf46 ("net/mlx5: DR, Support matching on tunnel headers 0 and 1")
  8c2b4fee9c4b ("net/mlx5: DR, Add misc5 to match_param structs")
  0f2a6c3b9219 ("net/mlx5: Add misc5 flow table match parameters")
  b54128275ef8 ("net/mlx5: DR, Warn on failure to destroy objects due to refcount")
  e3a0f40b2f90 ("net/mlx5: DR, Add support for UPLINK destination type")
  9222f0b27da2 ("net/mlx5: DR, Add support for dumping steering info")
  7766c9b922fe ("net/mlx5: DR, Add missing reserved fields to dr_match_param")
  89cdba3224f0 ("net/mlx5: DR, Add check for flex parser ID value")
  08fac109f7bb ("net/mlx5: DR, Rename list field in matcher struct to list_node")
  32e9bd585307 ("net/mlx5: DR, Remove unused struct member in matcher")
  c3fb0e280b4c ("net/mlx5: DR, Fix lower case macro prefix "mlx5_" to "MLX5_"")
  84dfac39c61f ("net/mlx5: DR, Fix error flow in creating matcher")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi all,

Commit

  8ca9caee851c ("net/mlx5: Lag, Make mlx5_lag_is_multipath() be static inline")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

Hi all,

Commit

  2d7e73f09fc2 ("Revert "Merge branch 'dsa-rtnl'"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well and should have reasonable messages (i.e.
why did you revert those changes) and SOBs.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

Hi all,

On Thu, 10 Dec 2020 21:37:13 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Commit
> 
>   5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block")
> 
> is missing a Signed-off-by from its committer.

Sorry, that is in the net tree (not net-next).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

Commits

  0d2ffdc8d400 ("net/mlx5: Don't call timecounter cyc2time directly from 1PPS flow")
  87f3495cbe8d ("net/mlx5: Release clock lock before scheduling a PPS work")
  aac2df7f022e ("net/mlx5: Rename ptp clock info")
  fb609b5112bd ("net/mlx5: Always use container_of to find mdev pointer from clock struct")
  ec529b44abfe ("net/mlx5: remove erroneous fallthrough")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Saeed Mahameed]

On Thu, 2020-09-17 at 08:31 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   0d2ffdc8d400 ("net/mlx5: Don't call timecounter cyc2time directly
> from 1PPS flow")
>   87f3495cbe8d ("net/mlx5: Release clock lock before scheduling a PPS
> work")
>   aac2df7f022e ("net/mlx5: Rename ptp clock info")
>   fb609b5112bd ("net/mlx5: Always use container_of to find mdev
> pointer from clock struct")
>   ec529b44abfe ("net/mlx5: remove erroneous fallthrough")
> 
> are missing a Signed-off-by from their committer.
> 

Sorry for the mix-up, i overwrote the old mlnx email address with the
new nvidia one but didn't consider the committer email :S.

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

Hi all,

Commit

  0093870aa891 ("batman-adv: Migrate to linux/prandom.h")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi all,

Commit

  6c4e9bcfb489 ("net/mlx5: Delete extra dump stack that gives nothing")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi all,

Commit

  1315971fea66 ("net/mlx5e: Fix missing switch_id for representors")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi all,

Commit

  07bab9502641 ("net/mlx5: E-Switch, Refactor eswitch ingress acl codes")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi all,

Commit

  be904b855200 ("sfc: make capability checking a nic_type function")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi all,

Commit

  26893e7e928e ("batman-adv: Utilize prandom_u32_max for random [0, max) values")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Commit

  a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 31 Oct 2019 18:10:44 +1100

> Commit
> 
>   a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm")
> 
> is missing a Signed-off-by from its committer.

Ok Jeff, that's two pull requests I've taken from you this week where
there were incorrect SHA1 IDs in Fixes tags or missing signoffs.

Please use some scripts or other forms of automation to keep this from
happening in the future.

Thank you.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Thu, 2019-10-31 at 10:40 -0700, David Miller wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 31 Oct 2019 18:10:44 +1100
> 
> > Commit
> > 
> >    a7023819404a ("e1000e: Use rtnl_lock to prevent race conditions
> > between net and pci/pm")
> > 
> > is missing a Signed-off-by from its committer.
> 
> Ok Jeff, that's two pull requests I've taken from you this week where
> there were incorrect SHA1 IDs in Fixes tags or missing signoffs.
> 
> Please use some scripts or other forms of automation to keep this
> from
> happening in the future.

Not sure what is going on to remove my SOB, since everything is
scripted, but I will look into it and I will add an additional check to
ensure future pull requests are not missing anything.  I apologize for
the missing SOB's.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi all,

Commit

  621650cabee5 ("i40e: Refactoring VF MAC filters counting to make more reliable")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

Commits

  0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file")
  21d549769e79 ("Isolate CAIF transport drivers into their own menu")
  0903102f5785 ("Clean up the net/caif/Kconfig menu")

are missing a Signed-off-by from their authors.

I guess <rd.dunlab@gmail.com> and <rdunlap@infradead.org> may be the
same person?  Please be consistent.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Randy Dunlap]

On 10/2/19 3:06 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   0f04f8ea62ce ("Minor fixes to the CAIF Transport drivers Kconfig file")
>   21d549769e79 ("Isolate CAIF transport drivers into their own menu")
>   0903102f5785 ("Clean up the net/caif/Kconfig menu")
> 
> are missing a Signed-off-by from their authors.
> 
> I guess <rd.dunlab@gmail.com> and <rdunlap@infradead.org> may be the
> same person?  Please be consistent.

  Yes.          Yes, will do that.

-- 
~Randy

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

Hi all,

Commit

  aa43ae121675 ("iwlwifi: LTR updates")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Luciano Coelho]

On Wed, 2019-09-11 at 00:42 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   aa43ae121675 ("iwlwifi: LTR updates")
> 
> is missing a Signed-off-by from its committer.

Oops, that was my fault.  What can we do about it? Is it enough if I
give my s-o-b publicly here?

I hereby sign off this change:

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>


--
Cheers,
Luca.

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

Hi all,

Commit

  9d71dd0c7009 ("can: add support of SAE J1939 protocol")

is missing a Signed-off-by from its author.

[Not sure if I should complain about this one ...]

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Oleksij Rempel]

Hi Stephen,

On Wed, Sep 11, 2019 at 12:41:03AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> 
> is missing a Signed-off-by from its author.
> 
> [Not sure if I should complain about this one ...]

Here is the original pull request message for this patch series:
"The final patch is the collective effort of many entities (The j1939
authors: Oliver Hartkopp, Bastian Stender, Elenita Hinds, kbuild test
robot, Kurt Van Dijck, Maxime Jayat, Robin van der Gracht, Oleksij
Rempel, Marc Kleine-Budde). It adds support of SAE J1939 protocol to the
CAN networking stack."
https://www.mail-archive.com/netdev@vger.kernel.org/msg313476.html

Since the patch can be hardly assigned to one author we deiced to use
address of CAN mailing list.

Best regards,
Oleksij Rempel
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

Hi all,

Commit

  6e52fca36c67 ("tc-tests: Add tc action ct tests")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 17 Jan 2019 08:06:19 +1100

> Hi all,
> 
> Commit
> 
>   a22d3251423f ("Fix ERROR:do not initialise statics to 0 in af_vsock.c")
> 
> is missing a Signed-off-by from its author.

I know, I caught it right after I pushed out, sorry :(

I really have to go back to working on that automation so this stops
happening.  My bad.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: lepton <ytht.net@gmail.com>
Date: Wed, 16 Jan 2019 14:27:45 -0800

> I sent another version with signed off serveral days ago:
> 
> https://www.spinics.net/lists/netdev/msg543829.html
> 
> So for some reason it got missed?

I didn't see it before I applied the initial patch because I was
heavily backlogged, I saw it afterwards...

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi all,

Commit

  f128f138cc40 ("net/mlx5e: Add ethtool control of ring params to VF representors")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Hi all,

Commit

  c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across multiple records")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Signed-off-by missing for commit in the net-next tree

[Vakul Garg]

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Monday, September 3, 2018 3:11 AM
> To: David Miller <davem@davemloft.net>; Networking
> <netdev@vger.kernel.org>
> Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Vakul Garg
> <vakul.garg@nxp.com>
> Subject: linux-next: Signed-off-by missing for commit in the net-next tree
> 
> Hi all,
> 
> Commit
> 
>   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
> multiple records")
> 
> is missing a Signed-off-by from its author.
> 

It is my fault to miss adding signoff.
I am sorry about that.
Please advise if I need to do something to fix it.
 

> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: Vakul Garg <vakul.garg@nxp.com>
Date: Mon, 3 Sep 2018 05:08:08 +0000

> 
>> -----Original Message-----
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Sent: Monday, September 3, 2018 3:11 AM
>> To: David Miller <davem@davemloft.net>; Networking
>> <netdev@vger.kernel.org>
>> Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
>> Mailing List <linux-kernel@vger.kernel.org>; Vakul Garg
>> <vakul.garg@nxp.com>
>> Subject: linux-next: Signed-off-by missing for commit in the net-next tree
>> 
>> Hi all,
>> 
>> Commit
>> 
>>   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
>> multiple records")
>> 
>> is missing a Signed-off-by from its author.
>> 
> 
> It is my fault to miss adding signoff.
> I am sorry about that.
> Please advise if I need to do something to fix it.

There is nothing you need to do, and since commits in my tree are immutable
once pushed out it cannot be fixed.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Hi Vakul,

On Mon, 3 Sep 2018 05:08:08 +0000 Vakul Garg <vakul.garg@nxp.com> wrote:
>
> > -----Original Message-----
> > Commit
> > 
> >   c2ad647c6442 ("selftests/tls: Add test for recv(PEEK) spanning across
> > multiple records")
> > 
> > is missing a Signed-off-by from its author.
> 
> It is my fault to miss adding signoff.

See section 11 of Documentation/process/submitting-patches.rst.

> I am sorry about that.

It happens ...

> Please advise if I need to do something to fix it.

Dave's tree does not rebase, so nothing can be done about this case.  I
guess you should just remember to add a Signed-off-by line in the
future.  Also, Dave should probably check before publishing to his tree.

That being said, I have not seen many like this in Dave's tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,
Commit

  2db6dc2662ba ("sch_cake: Make gso-splitting configurable from userspace")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

Hi all,

Commit

  9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  cbad52e92ad7 ("sfc: don't warn on successful change of MAC")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")

is missing a Signed-off-by from its author (or its author is wrong).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Kirill Smelkov]

Francois,

On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")
> 
> is missing a Signed-off-by from its author (or its author is wrong).

Could we please get signoff for this your patch from 2012 which I've
reworked a bit to be commit 509708310cf9 ?

    	https://www.spinics.net/lists/netdev/msg217984.html
    	https://www.spinics.net/lists/netdev/msg218207.html

I was keeping you in To and Cc all the time but got no reply at all since my
first posting from ~ 1 month ago.

Thanks beforehand,
Kirill

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Eric Dumazet]

On Tue, 2017-10-31 at 09:14 +0300, Kirill Smelkov wrote:
> Francois,
> 
> On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")
> > 
> > is missing a Signed-off-by from its author (or its author is wrong).
> 
> Could we please get signoff for this your patch from 2012 which I've
> reworked a bit to be commit 509708310cf9 ?
> 
>     	https://www.spinics.net/lists/netdev/msg217984.html
>     	https://www.spinics.net/lists/netdev/msg218207.html
> 
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

Nothing we can do, patch is merged, we can not modify it anymore.

You provided all the rationale in the changelog, so no worries.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Francois Romieu]

Kirill Smelkov <kirr@nexedi.com> :
[...]
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

I thought it was longer than that. Sorry for the frustrating excess delay.

As Eric already said there is no problem and I am perfectly fine with
the current attribution of this code.

Use of errno.h::ELNRNG is really unusual but it's a different topic.

-- 
Ueimor

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Kirill Smelkov]

Francois,

On Wed, Nov 01, 2017 at 11:55:24AM +0100, Francois Romieu wrote:
> Kirill Smelkov <kirr@nexedi.com> :
> [...]
> > I was keeping you in To and Cc all the time but got no reply at all since my
> > first posting from ~ 1 month ago.
> 
> I thought it was longer than that. Sorry for the frustrating excess delay.
> 
> As Eric already said there is no problem and I am perfectly fine with
> the current attribution of this code.

Thanks for feedback.

> Use of errno.h::ELNRNG is really unusual but it's a different topic.

I wanted the error returned due to internal inconsistency to be different
from the error returned when there is error in provided parameters from
ethtool.

Your original patch was returning EINVAL for both cases which made it
hard to understand what is going on when the kernel was refusing to
accept something from user.

That's why I used ELNRNG (link number out of range) for situation when
lookup of timings vector by current link speed failed. A bit unusual,
yes, but this was the closest to the situation after studying `errno -l`
output.

Hope this clarifies a bit.

Please feel free to suggest a change here,
Kirill

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Ahern]

On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
> 
> is missing a Signed-off-by from its author.
> 

Eric pointed this out last night. The commit message copied output from
a command that contained '---' so git ignored the remainder of the message.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi David,

On Wed, 30 Aug 2017 10:53:48 -0600 David Ahern <dsahern@gmail.com> wrote:
>
> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
> > 
> > is missing a Signed-off-by from its author.
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Rats!

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: David Ahern <dsahern@gmail.com>
Date: Wed, 30 Aug 2017 10:53:48 -0600

> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commit
>> 
>>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")
>> 
>> is missing a Signed-off-by from its author.
>> 
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Yes, it unfortunately got clipped off by GIT due to how the
commit message was written. :(