From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A67C5DF62 for ; Tue, 5 Nov 2019 21:37:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 762A121A49 for ; Tue, 5 Nov 2019 21:37:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mGCuTlCI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729981AbfKEVhs (ORCPT ); Tue, 5 Nov 2019 16:37:48 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:41039 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729830AbfKEVhr (ORCPT ); Tue, 5 Nov 2019 16:37:47 -0500 Received: by mail-qt1-f195.google.com with SMTP id o3so31308680qtj.8; Tue, 05 Nov 2019 13:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UdTF48D5Kt/CE3Gcwyq07ed3jwz9oZyEExI7mYpVFj0=; b=mGCuTlCIywx7flepTari4xa/KazmeMpZL8TxPtn6RyWbUMfz/7Ss2onvHED4Tqz1Hl sgGfJUAw8swFR7bbiWogiXfUv4WxHadAKYqHwUPw2bpZeoYynAQJWpmu7EbIyUSE9cki kfIYEwtuKU7HEfnYXWY5R1jVQWHozeBaw9EGnMMANRg4yGHp1RDeaIQAVqSVnM7yAfm9 4SHXHQt0pjkq727UmYalY0ic+l6nsH2bNyEWa/SXkdcv64cEPJe+jipMuQ9swMtx33mP DWSJz1fN96TBUmj6aKA+E7Q/sdSLwTvPhlUSx7zjD9/AtU1iuBSafKVWNyjM0u6nMeWx 08nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UdTF48D5Kt/CE3Gcwyq07ed3jwz9oZyEExI7mYpVFj0=; b=pcTZZQWM0K9keFEkilcQ/YO55QDHeNR9KvczV5iC8xXvPRplKCYfhMxl5hwvZ6PEbq vnb9AnjNSG09Ll/SsnNNxHMldOF0Fp+4TvYiwaFHwrebY6AoHjWkMNBga9i6nfnDPTof wg26+48Qk3Ek5ukqhStCTU5N6oGqb0c2FlRvrCFoRz9qNpaFlPnJmOv7yksI6Ba+2mTt h8fXqMJE9oZYxtRJntWuu7aCmyEGSj4Gnl+Ka4NilkUqiaZO8eKhza1IGnGkqWVZiipz P6FozT6G+fYLFyo+qNLejNeRawYRAgRQcKHhFayjT2ubTmqOHzqAt3EMVnYlP47aFmO5 1FDQ== X-Gm-Message-State: APjAAAVcDuK/Anwlx8xSLRGx0oORETOA0CDjfNDr1lGQ1OdXs7q8KHL6 OflTi+k7Ze35Soq5mYBr+7op3q4hvmPDXsM3pjI= X-Google-Smtp-Source: APXvYqwhQcfSRtp91KwBkkmkWWAs1ZaKnh4kJpbPY5LRcJ/+zI1oXSCI6xkhwq91Vzch79szgnn340NqLi3i2mWiQno= X-Received: by 2002:ac8:199d:: with SMTP id u29mr18905966qtj.93.1572989864989; Tue, 05 Nov 2019 13:37:44 -0800 (PST) MIME-Version: 1.0 References: <20191102220025.2475981-1-ast@kernel.org> <20191102220025.2475981-6-ast@kernel.org> In-Reply-To: <20191102220025.2475981-6-ast@kernel.org> From: Andrii Nakryiko Date: Tue, 5 Nov 2019 13:37:33 -0800 Message-ID: Subject: Re: [PATCH bpf-next 5/7] selftest/bpf: Simple test for fentry/fexit To: Alexei Starovoitov Cc: "David S. Miller" , Daniel Borkmann , Peter Ziljstra , Steven Rostedt , x86@kernel.org, Networking , bpf , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Nov 2, 2019 at 3:04 PM Alexei Starovoitov wrote: > > Add simple test for fentry and fexit programs around eth_type_trans. > > Signed-off-by: Alexei Starovoitov > --- LGTM, but please fix formatting. Acked-by: Andrii Nakryiko > .../selftests/bpf/prog_tests/kfree_skb.c | 37 +++++++++++-- > tools/testing/selftests/bpf/progs/kfree_skb.c | 52 +++++++++++++++++++ > 2 files changed, 86 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/kfree_skb.c b/tools/testing/selftests/bpf/prog_tests/kfree_skb.c > index 430b50de1583..d3402261bbae 100644 > --- a/tools/testing/selftests/bpf/prog_tests/kfree_skb.c > +++ b/tools/testing/selftests/bpf/prog_tests/kfree_skb.c > @@ -30,15 +30,17 @@ void test_kfree_skb(void) > .file = "./kfree_skb.o", > }; > > + struct bpf_link *link = NULL, *link_fentry = NULL, *link_fexit = NULL; > + struct bpf_program *prog, *fentry, *fexit; > struct bpf_object *obj, *obj2 = NULL; > struct perf_buffer_opts pb_opts = {}; > struct perf_buffer *pb = NULL; > - struct bpf_link *link = NULL; > - struct bpf_map *perf_buf_map; > - struct bpf_program *prog; > + struct bpf_map *perf_buf_map, *global_data; > __u32 duration, retval; > int err, pkt_fd, kfree_skb_fd; > bool passed = false; > + const int zero = 0; > + bool test_ok[2]; > > err = bpf_prog_load("./test_pkt_access.o", BPF_PROG_TYPE_SCHED_CLS, &obj, &pkt_fd); too long ;) > if (CHECK(err, "prog_load sched cls", "err %d errno %d\n", err, errno)) > @@ -51,9 +53,26 @@ void test_kfree_skb(void) > prog = bpf_object__find_program_by_title(obj2, "tp_btf/kfree_skb"); > if (CHECK(!prog, "find_prog", "prog kfree_skb not found\n")) > goto close_prog; > + fentry = bpf_object__find_program_by_title(obj2, "fentry/eth_type_trans"); > + if (CHECK(!fentry, "find_prog", "prog eth_type_trans not found\n")) > + goto close_prog; > + fexit = bpf_object__find_program_by_title(obj2, "fexit/eth_type_trans"); > + if (CHECK(!fexit, "find_prog", "prog eth_type_trans not found\n")) > + goto close_prog; > + > + global_data = bpf_object__find_map_by_name(obj2, "kfree_sk.bss"); > + if (CHECK(!global_data, "find global data", "not found\n")) > + goto close_prog; > + > link = bpf_program__attach_raw_tracepoint(prog, NULL); > if (CHECK(IS_ERR(link), "attach_raw_tp", "err %ld\n", PTR_ERR(link))) > goto close_prog; > + link_fentry = bpf_program__attach_trace(fentry); > + if (CHECK(IS_ERR(link_fentry), "attach fentry", "err %ld\n", PTR_ERR(link_fentry))) > + goto close_prog; > + link_fexit = bpf_program__attach_trace(fexit); > + if (CHECK(IS_ERR(link_fexit), "attach fexit", "err %ld\n", PTR_ERR(link_fexit))) checkpatch.pl? > + goto close_prog; > [...]