From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF02C2D0EB for ; Sun, 29 Mar 2020 20:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F31E32074A for ; Sun, 29 Mar 2020 20:14:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YBVntn9W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728502AbgC2UOG (ORCPT ); Sun, 29 Mar 2020 16:14:06 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:41498 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727606AbgC2UOG (ORCPT ); Sun, 29 Mar 2020 16:14:06 -0400 Received: by mail-qt1-f193.google.com with SMTP id i3so13396444qtv.8; Sun, 29 Mar 2020 13:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=V9/YiousU3cFLlbSDBU5cLChHej2btokTY5DS/F3EDo=; b=YBVntn9W3uR2Hr6KMbpgQfjW8HSST8C1kTwxXURki6fn3SS6N5MgHGBrVyfOmr6Gnz 6A9JYSka3RYlyjxji0zXYFW5YWvC4WVgZFXuCEsIwQSH2fngyD0iS+AlmKPQgEyYZTIv DrQ2ISVPpR/+VQEad2L6/Qssd/qjEqQOliGPlPCUfduINr1mxuapx+OpYY3F2BYfuHwN Z7SaKk4gnr4Ochay5IHMc2SfDtx5eZrVpu5sUyVtdG77q4ke4O1wOw5bN9uyd4efWGc1 3HJipgjidkZGM/mKhHKY9NxYG32kie/YUDQs/0OLY776qTfOCa0Xu37Xi49d8Q789UG6 lUew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V9/YiousU3cFLlbSDBU5cLChHej2btokTY5DS/F3EDo=; b=L45FGh8Q5r0KS5oSs9R74NPZ7+nlUi1xvsImbGDl+8Amce6JCcVLJswWNL3YVqwYEc n3EQMM/Yh8BhkKl00PFJpA5aQQDtYcI9wV394jY6xMASRnokTjBg9yPne4pNhFsNbqqL bI3D6tYfOm0snHMIM9Gzp/uDl4t2n9Rd15I4SOuNO4YX2cMOa5/wvc86NGEnhQDAzwWw 5O/JZdKqvc79xWsFgfV5J7HPU3JGsizfFwjXVgvNCAfaE5RQQS1X8ras2+MIvretiiOV M56c9TZp6dSjsrZpkWcY3BxPuU9XIcH7N/yL2sWF2aQsA7mfuZzKtARkIu3mZ/wi9rek D7Yg== X-Gm-Message-State: ANhLgQ2J/0lGmZMQiLv4rr8XWMW36+mipEgOxcQnGSwoo8EnLIUlaCoq Ac5eR0jgUhQ8h2JOqS0OHYWMP6H66JRIsvBjIE5Gz5re X-Google-Smtp-Source: ADFU+vuIyMQmdGYyF5yaa0KOlo5J6IlpSFfCBzWyJcvovssgX0Opo+Ex3fVZkukn+SqdclA4TrP2DfUTH54cpn5CV/M= X-Received: by 2002:ac8:6918:: with SMTP id e24mr8786477qtr.141.1585512843429; Sun, 29 Mar 2020 13:14:03 -0700 (PDT) MIME-Version: 1.0 References: <20200328182834.196578-1-toke@redhat.com> <20200329132253.232541-2-toke@redhat.com> In-Reply-To: <20200329132253.232541-2-toke@redhat.com> From: Andrii Nakryiko Date: Sun, 29 Mar 2020 13:13:52 -0700 Message-ID: Subject: Re: [PATCH v4 2/2] selftests: Add test for overriding global data value before load To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , bpf , Networking Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 29, 2020 at 6:23 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > This adds a test to exercise the new bpf_map__set_initial_value() functio= n. > The test simply overrides the global data section with all zeroes, and > checks that the new value makes it into the kernel map on load. > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- I guess given you don't attach or run any BPF program, it's fine to reuse test_global_data.o for this. Acked-by: Andrii Nakryiko > .../bpf/prog_tests/global_data_init.c | 61 +++++++++++++++++++ > .../selftests/bpf/progs/test_global_data.c | 2 +- > 2 files changed, 62 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/global_data_in= it.c > [...]