Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>
Cc: "Daniel Borkmann" <daniel@iogearbox.net>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Andrii Nakryiko" <andriin@fb.com>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] samples: bpf: fix outdated README build command
Date: Sun, 10 Nov 2019 22:09:34 -0800
Message-ID: <CAEf4BzYRqeg5vFm+Ac2TVVeAw=N+qhosy5qF9Dr_ka3hn8DsPg@mail.gmail.com> (raw)
In-Reply-To: <20191110081901.20851-1-danieltimlee@gmail.com>

On Sun, Nov 10, 2019 at 12:19 AM Daniel T. Lee <danieltimlee@gmail.com> wrote:
>
> Currently, building the bpf samples under samples/bpf directory isn't
> working. Running make from the directory 'samples/bpf' will just shows
> following result without compiling any samples.
>

Do you mind trying to see if it's possible to detect that plain `make`
is being run from samples/bpf subdirectory, and if that's the case,
just running something like `make M=samples/bpf -C ../../`? If that's
not too hard, it would be a nice touch to still have it working old
(and intuitive) way, IMO.


>  $ make
>  make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/linux/samples/bpf
>  make[1]: Entering directory '/git/linux'
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/atomic/check-atomics.sh
>    DESCEND  objtool
>  make[1]: Leaving directory '/git/linux'
>
> Due to commit 394053f4a4b3 ("kbuild: make single targets work more
> correctly"), building samples/bpf without support of samples/Makefile
> is unavailable. Instead, building the samples with 'make M=samples/bpf'
> from the root source directory will solve this issue.[1]
>
> This commit fixes the outdated README build command with samples/bpf.
>
> [0]: https://patchwork.kernel.org/patch/11168393/
>
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
> ---
>  samples/bpf/README.rst | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>

[...]

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10  8:19 Daniel T. Lee
2019-11-11  6:09 ` Andrii Nakryiko [this message]
2019-11-11  9:24   ` Toke Høiland-Jørgensen
2019-11-12 11:47     ` Daniel T. Lee
2019-11-12 11:45   ` Daniel T. Lee
2019-11-11 13:58 ` Daniel Borkmann
2019-11-12 11:48   ` Daniel T. Lee

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzYRqeg5vFm+Ac2TVVeAw=N+qhosy5qF9Dr_ka3hn8DsPg@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=danieltimlee@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git