From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4E6C433E6 for ; Tue, 23 Feb 2021 01:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F59E64E12 for ; Tue, 23 Feb 2021 01:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbhBWBuI (ORCPT ); Mon, 22 Feb 2021 20:50:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhBWBtp (ORCPT ); Mon, 22 Feb 2021 20:49:45 -0500 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E6C8C06178B; Mon, 22 Feb 2021 17:49:30 -0800 (PST) Received: by mail-yb1-xb36.google.com with SMTP id m188so14873100yba.13; Mon, 22 Feb 2021 17:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=19ACJ1fic9mV42uUnpDAFR0NZ9Dw4Na6mJs9CQ+BSWg=; b=LypvH1qwGsVnZ8ZohpQWT3wOTzQUY3BqElmAqgaZr4BPNIaeI1kBcCx6SfsJqXnwoh TcCi0mVLgVq1rgNmk4lgqzuJYTQkr4wmzjOeFxq6RWgkRV6KEpqtdeBaj+txAaILT6D4 7x5BAnF5r0HwLXrIjiELyGzGBhRvCtBx5Dtlt5vOzhtuNzbmixXdhjQohFtBqSnx/iFz BNsloVWAXfPcFfrC1JwPuSpjNyqZ84h+7rRDmB7uqj+eai2L+KKhUGN10myNtx8U02qz OBxifP1GBB50yLN84rVh/+GKeBsex07iI4Sn4tdTSyR/Eea2hcCq5B9KKnZkC7XLqIA4 8m0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=19ACJ1fic9mV42uUnpDAFR0NZ9Dw4Na6mJs9CQ+BSWg=; b=R8N7IZJC8+KLEBsK2kLcySZlQaP9vGnh5ctiPTuXkRMErVcGvTiTqP0raWryhtPa5x HsFCWP3TZnz5fPu/g/WJUnjbu44U0PVF6lGKyfT9YuqhodxgeAQyCxfRPg73BI+mN2C2 kQtG97N2RESuaW1hFn6qvmLIdkx/nQ/E35LcGF84R8D/DmMnyiUxCu0JjkoeiaSTOUfi R2u/M1sChJz4BjUML+6+405SwP0LTwYFAR+4MAMMmz2/B2d0Hdo7rfAlG9VmjpEkFUGp AoNMifc7qtMHnvn+0SRKyG0VfxoJhuxpE42TgslhdUMulVYom1h73TvrL6NUlwZr92d5 JIHA== X-Gm-Message-State: AOAM532Ybr1IpLmtudkwL/BPmGXwS87eujbl7IM7YtigNn7TWcwOQS0T MHi/1a6+c2uy+hcfkV4Fm8QMbvnhSPSgMiVJ4QY= X-Google-Smtp-Source: ABdhPJxHTS4veMmCO+YwBwO5wCQlc7azPHJKmPse8N4xGOxspLGx1U3QlklOpHhoaiKCDPOmRgncCd9mQlj9wCCsuA0= X-Received: by 2002:a25:abb2:: with SMTP id v47mr36212197ybi.425.1614044969515; Mon, 22 Feb 2021 17:49:29 -0800 (PST) MIME-Version: 1.0 References: <1613812247-17924-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1613812247-17924-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Andrii Nakryiko Date: Mon, 22 Feb 2021 17:49:18 -0800 Message-ID: Subject: Re: [PATCH] libbpf: Remove unnecessary conversion to bool To: Jiapeng Chong Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Nathan Chancellor , Nick Desaulniers , Networking , bpf , open list , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 20, 2021 at 1:11 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./tools/lib/bpf/libbpf.c:1487:43-48: WARNING: conversion to bool not > needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- I think this came up before already. I did this on purpose and I'd like to keep it that way in the code. > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 6ae748f..5dfdbf3 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -1484,7 +1484,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val, > ext->name, value); > return -EINVAL; > } > - *(bool *)ext_val = value == 'y' ? true : false; > + *(bool *)ext_val = value == 'y'; > break; > case KCFG_TRISTATE: > if (value == 'y') > -- > 1.8.3.1 >