From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C0FC17442 for ; Fri, 8 Nov 2019 22:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FE55215EA for ; Fri, 8 Nov 2019 22:52:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AYVw3DrK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727647AbfKHWwU (ORCPT ); Fri, 8 Nov 2019 17:52:20 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:46885 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfKHWwU (ORCPT ); Fri, 8 Nov 2019 17:52:20 -0500 Received: by mail-qk1-f196.google.com with SMTP id h15so6728925qka.13; Fri, 08 Nov 2019 14:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WMQDp49yeXvamrrdeakb+3cfl6V33i1WwQsMuj7jjPg=; b=AYVw3DrKG3GxagsN8rKObOOVrn4CPrpB0vVrR9MVrSaDOdmPzPsJ7F2Fxq9oa+fUYk nJ4wj0Q3VGPE0E1+bjMdDoU/yiGbm/9BIdueh+csAMljamKoppHFo4fFPJfUpevxylVk KGdr1OoiDiNsP/JjGohTufKHciWOkAmS775EibBOXzhEQbBq8XZBZuzMpORlysuC+X1x zVkAn0SD7bSzn7XAUC+wV1+F8/9ZAPkE4pttf7K/kkU2bboquoDlhFVvlr48i9RqeL9E IDPCIlDNNe23I+zDOsM+OCPmAVSlAPSFe2HUI9IYmFbY+t1v6A5c2wmegBPeWcFCO8YV 9MNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WMQDp49yeXvamrrdeakb+3cfl6V33i1WwQsMuj7jjPg=; b=rrPTfDgSYbarjOeIdMQJDEubWTDpjHnBUKxvcJpQzqyksryDNGzgzl4Ha7WNENGw52 v/gcf0rN0ExOCmaAuwsvEvyJxF9kRXKLsDmyt18MhLIeR44+DrQ2e7vrZeFyd870mxBH 6DYiV2YXLd6VY8rXiBxazkbi4SCPxVybMG9swFMDT5riVHdCn0/yUZdYMb4Y01uL1z3c 6DXxUH/MOnagVQMpLQo4IZpL8yG48GCLKzVTX32A1SJ1ZozTxAgAZBCoXTAK1jXNAHul pHodzaeNFeFe1A4z8o0MQq0a1giwWKqarhnatLlDRF9218/nGpiwv6QuLctARIHogA68 O27A== X-Gm-Message-State: APjAAAVd/7K9ApMko04TRs2mfZT/atwKb8X4bFwpsB4Fu42Vjn76Sfgp mAIQb+F6o3IsSWOKJm+HivKjrKVm8EWGY90ECww= X-Google-Smtp-Source: APXvYqzYejG/fDn6vhyMUvuHvNnHceBUc9Ogoc7tfQUy3P7lt7ElbnrmNB7a7EVhEC6h8zuYo4amdeEg7TgCsDpV0C4= X-Received: by 2002:a37:9a8a:: with SMTP id c132mr11319906qke.92.1573253537715; Fri, 08 Nov 2019 14:52:17 -0800 (PST) MIME-Version: 1.0 References: <157324878503.910124.12936814523952521484.stgit@toke.dk> <157324878956.910124.856248605977418231.stgit@toke.dk> In-Reply-To: <157324878956.910124.856248605977418231.stgit@toke.dk> From: Andrii Nakryiko Date: Fri, 8 Nov 2019 14:52:06 -0800 Message-ID: Subject: Re: [PATCH bpf-next v2 4/6] libbpf: Use pr_warn() when printing netlink errors To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Jesper Dangaard Brouer , David Miller , Networking , bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 8, 2019 at 1:33 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > From: Toke H=C3=B8iland-J=C3=B8rgensen > > The netlink functions were using fprintf(stderr, ) directly to print out > error messages, instead of going through the usual logging macros. This > makes it impossible for the calling application to silence or redirect > those error messages. Fix this by switching to pr_warn() in nlattr.c and > netlink.c. > > Acked-by: Song Liu > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- Acked-by: Andrii Nakryiko > tools/lib/bpf/netlink.c | 3 ++- > tools/lib/bpf/nlattr.c | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > [...]