From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/6] libbpf: add internal helper to load BTF data by FD
Date: Fri, 20 Nov 2020 10:25:21 -0800 [thread overview]
Message-ID: <CAEf4BzZmkR80AF-gz6NyLH21q=un1Wfpobo=TwpahX+YJ-t3ww@mail.gmail.com> (raw)
In-Reply-To: <20201120182019.zlzmntlnaewcc5ue@kafai-mbp.dhcp.thefacebook.com>
On Fri, Nov 20, 2020 at 10:20 AM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Thu, Nov 19, 2020 at 03:22:40PM -0800, Andrii Nakryiko wrote:
> [ ... ]
>
> > +int btf__get_from_id(__u32 id, struct btf **btf)
> > +{
> > + struct btf *res;
> > + int btf_fd;
> > +
> > + *btf = NULL;
> > + btf_fd = bpf_btf_get_fd_by_id(id);
> > + if (btf_fd < 0)
> > + return 0;
> It should return an error.
>
That would break the original behavior with (ret == 0 && btf == NULL),
but I think it's more consistent, so I'll fix this and will add Fixes:
tag.
> > +
> > + res = btf_get_from_fd(btf_fd, NULL);
> > + close(btf_fd);
> > + if (IS_ERR(res))
> > + return PTR_ERR(res);
> > +
> > + *btf = res;
> > + return 0;
> > }
> >
next prev parent reply other threads:[~2020-11-20 18:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 23:22 [PATCH bpf-next 0/6] libbpf: add support for kernel module BTF CO-RE relocations Andrii Nakryiko
2020-11-19 23:22 ` [PATCH bpf-next 1/6] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address() Andrii Nakryiko
2020-11-20 17:55 ` Martin KaFai Lau
2020-11-24 5:49 ` Alexei Starovoitov
2020-11-24 7:49 ` Andrii Nakryiko
2020-11-19 23:22 ` [PATCH bpf-next 2/6] libbpf: add internal helper to load BTF data by FD Andrii Nakryiko
2020-11-20 18:20 ` Martin KaFai Lau
2020-11-20 18:25 ` Andrii Nakryiko [this message]
2020-11-19 23:22 ` [PATCH bpf-next 3/6] libbpf: refactor CO-RE relocs to not assume a single BTF object Andrii Nakryiko
2020-11-20 22:11 ` Martin KaFai Lau
2020-11-19 23:22 ` [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations Andrii Nakryiko
2020-11-20 0:46 ` Maciej Fijalkowski
2020-11-20 1:24 ` Andrii Nakryiko
2020-11-20 2:05 ` Maciej Fijalkowski
2020-11-20 3:31 ` Andrii Nakryiko
2020-11-20 23:05 ` Martin KaFai Lau
2020-11-20 23:12 ` Andrii Nakryiko
2020-11-19 23:22 ` [PATCH bpf-next 5/6] selftests/bpf: add bpf_sidecar kernel module for testing Andrii Nakryiko
2020-11-20 23:21 ` Martin KaFai Lau
2020-11-19 23:22 ` [PATCH bpf-next 6/6] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF Andrii Nakryiko
2020-11-20 23:27 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZmkR80AF-gz6NyLH21q=un1Wfpobo=TwpahX+YJ-t3ww@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).