From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 3/4] bpf: Add kernel module with user mode driver that populates bpffs.
Date: Mon, 3 Aug 2020 11:08:40 -0700 [thread overview]
Message-ID: <CAEf4BzZp+uc0n=A9=x3T=5ii2J5x_tu_0ZOYKoUQ-r39GJM3DQ@mail.gmail.com> (raw)
In-Reply-To: <181ce3e4-c960-3470-5c08-3e56ea7f28b2@iogearbox.net>
On Mon, Aug 3, 2020 at 10:56 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> On 8/3/20 7:51 PM, Andrii Nakryiko wrote:
> > On Mon, Aug 3, 2020 at 10:41 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
> >> On 8/3/20 7:34 PM, Daniel Borkmann wrote:
> >>> On 8/3/20 7:15 PM, Daniel Borkmann wrote:
> >>>> On 8/3/20 12:29 AM, Alexei Starovoitov wrote:
> >>>>> From: Alexei Starovoitov <ast@kernel.org>
> >>>>>
> >>>>> Add kernel module with user mode driver that populates bpffs with
> >>>>> BPF iterators.
> >>>>>
> >
> > [...]
> >
> >> CC kernel/events/ring_buffer.o
> >> CC [U] kernel/bpf/preload/./../../../tools/lib/bpf/bpf.o
> >> CC [U] kernel/bpf/preload/./../../../tools/lib/bpf/libbpf.o
> >> In file included from kernel/bpf/preload/./../../../tools/lib/bpf/libbpf.c:47:0:
> >> ./tools/include/tools/libc_compat.h:11:21: error: static declaration of ‘reallocarray’ follows non-static declaration
> >> static inline void *reallocarray(void *ptr, size_t nmemb, size_t size)
> >> ^~~~~~~~~~~~
> >> In file included from kernel/bpf/preload/./../../../tools/lib/bpf/libbpf.c:16:0:
> >> /usr/include/stdlib.h:558:14: note: previous declaration of ‘reallocarray’ was here
> >> extern void *reallocarray (void *__ptr, size_t __nmemb, size_t __size)
> >> ^~~~~~~~~~~~
> >
> > A bit offtopic. reallocarray and related feature detection causes so
> > much hassle, that I'm strongly tempted to just get rid of it in the
> > entire libbpf. Or just unconditionally implement libbpf-specific
> > reallocarray function. Any objections?
>
> Agree that it's continuously causing pain; no objection from my side to have
> something libbpf-specifc for example (along with a comment on /why/ we're not
> reusing it anymore).
Sounds good!
>
> >> CC kernel/user-return-notifier.o
> >> scripts/Makefile.userprogs:43: recipe for target 'kernel/bpf/preload/./../../../tools/lib/bpf/libbpf.o' failed
> >> make[3]: *** [kernel/bpf/preload/./../../../tools/lib/bpf/libbpf.o] Error 1
> >> scripts/Makefile.build:497: recipe for target 'kernel/bpf/preload' failed
> >> make[2]: *** [kernel/bpf/preload] Error 2
> >> scripts/Makefile.build:497: recipe for target 'kernel/bpf' failed
> >> make[1]: *** [kernel/bpf] Error 2
> >> make[1]: *** Waiting for unfinished jobs....
> >> [...]
next prev parent reply other threads:[~2020-08-03 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 22:29 [PATCH v5 bpf-next 0/4] bpf: Populate bpffs with map and prog iterators Alexei Starovoitov
2020-08-02 22:29 ` [PATCH v5 bpf-next 1/4] bpf: Factor out bpf_link_by_id() helper Alexei Starovoitov
2020-08-02 22:29 ` [PATCH v5 bpf-next 2/4] bpf: Add BPF program and map iterators as built-in BPF programs Alexei Starovoitov
2020-08-02 22:29 ` [PATCH v5 bpf-next 3/4] bpf: Add kernel module with user mode driver that populates bpffs Alexei Starovoitov
2020-08-03 17:15 ` Daniel Borkmann
2020-08-03 17:34 ` Daniel Borkmann
2020-08-03 17:40 ` Daniel Borkmann
2020-08-03 17:51 ` Andrii Nakryiko
2020-08-03 17:56 ` Daniel Borkmann
2020-08-03 18:08 ` Andrii Nakryiko [this message]
2020-08-03 18:33 ` Alexei Starovoitov
2020-08-03 19:31 ` Daniel Borkmann
2020-08-02 22:29 ` [PATCH v5 bpf-next 4/4] selftests/bpf: Add bpffs preload test Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZp+uc0n=A9=x3T=5ii2J5x_tu_0ZOYKoUQ-r39GJM3DQ@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).