From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF42EC31E5D for ; Mon, 17 Jun 2019 17:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBF142084D for ; Mon, 17 Jun 2019 17:46:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i5kKTxj3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbfFQRqs (ORCPT ); Mon, 17 Jun 2019 13:46:48 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:36827 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfFQRqs (ORCPT ); Mon, 17 Jun 2019 13:46:48 -0400 Received: by mail-qt1-f195.google.com with SMTP id p15so11786396qtl.3; Mon, 17 Jun 2019 10:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sEeLyWIWaH8yI5NmJgm9tYs+wDDYp+k6X7WJXQxU9Kk=; b=i5kKTxj35ZuRu49cy7EVfO+BE0FVenJWi19z6yNiyB2f/Y9QSHuX9eXqW2ThX5+eXS TLnTNF+Us+6ZUvUbyhZu0AKu1BU7hdsW+gNkev7HHfKyuJILEKS3Wj/CVe3pXBaUZKfH t3LpJMpojH0vXS0NMwx5Pg7caX6wf7qIS8nyfg2HmKHYGNdjVSTOlXEWOhnXq6ZldTwO 1M8R8L9wx0cBgQT4sMp7Gfi2JnmVFykABA6csoaeHo+0LeQmkjcUmidD+SBxHADWPDm/ jQX3h+URcK5MsShKDM5NOIbK3Z/IpWvzTyaLFMhhrsjnh+ge7X7UFqbjtVD2iiEk3q9p MvkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sEeLyWIWaH8yI5NmJgm9tYs+wDDYp+k6X7WJXQxU9Kk=; b=Vj7YdDxsqLg5LuhXBKrajktdGpO+lYWwELDWOBSUmBeoOljORAxkKySd55V/B3fUAV J2pTQGosQp8JrBZrKglOoP/oeVrXmsDaht1/20MZ7HdzZam5qXrinOWREBT0U7NZYh2g PaGKU1tb9CmCp8CfU6CP7uJ74b1MyHI/Hb/y4f/rLjJjTHni5F9ZMUBxy9MnqHungOel RQO7DQvBhHlJMxW7LH0X70NAvyoaj/Wy9RtqJIMxbiuiqqvAUEK6m9WHSt2hY8APwexq uxJnoraQt+hWezjN1QkNGnUB9Y7suVQtBQ7NYS3yiWlEfgCJRa6vj/l7Tq6XRkvbOHpt xDBQ== X-Gm-Message-State: APjAAAVvzju1UJ3EnDCs9T6HiCDHn0oLaaJh9UQX71UCKkTRr8/ytiQc 02HrFX2P097ZcAO/2sbo/oeCLd/UuqQLYRuHBeQ= X-Google-Smtp-Source: APXvYqwPNxBYMedmrITaWowP1jKt0wA9g6fV5eP/gSDyN6PhXLy/3tJGpG9GvJZbcCZfIuO44nTOnGnSEmpxACLxsHI= X-Received: by 2002:ac8:290c:: with SMTP id y12mr6798241qty.141.1560793605756; Mon, 17 Jun 2019 10:46:45 -0700 (PDT) MIME-Version: 1.0 References: <20190611044747.44839-1-andriin@fb.com> <20190611044747.44839-3-andriin@fb.com> In-Reply-To: From: Andrii Nakryiko Date: Mon, 17 Jun 2019 10:46:34 -0700 Message-ID: Subject: Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic To: Song Liu Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jun 15, 2019 at 1:28 PM Song Liu wrote: > > On Sat, Jun 15, 2019 at 1:25 PM Song Liu wrote: > > > > On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > > > > > > As a preparation for adding BTF-based BPF map loading, extract .BTF and > > > .BTF.ext loading logic. Also simplify error handling in > > > bpf_object__elf_collect() by returning early, as there is no common > > > clean up to be done. > > Maybe separate bpf_object__load_btf() and other cleanup in two patches? > (I won't complain if you keep them together) Split into two. > > Thanks, > Song > > > > > > > Signed-off-by: Andrii Nakryiko > > > --- > > > tools/lib/bpf/libbpf.c | 137 ++++++++++++++++++++++------------------- > > > 1 file changed, 75 insertions(+), 62 deletions(-)