From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BF5C433F5 for ; Fri, 20 May 2022 22:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353820AbiETWFF (ORCPT ); Fri, 20 May 2022 18:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243602AbiETWFD (ORCPT ); Fri, 20 May 2022 18:05:03 -0400 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE7A13F90; Fri, 20 May 2022 15:05:02 -0700 (PDT) Received: by mail-vs1-xe30.google.com with SMTP id m2so9618787vsr.8; Fri, 20 May 2022 15:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vEa8wOAy1yjkPGX5niq7cKlzEqEbn5vgGX01uFZeyx0=; b=pf70By7pF1e4r2VxjsJ+FR0Y8tv1NHuzHngxTbWZ4GdEEmJFJRgFbpOAbwK+6OMDmo HOvHve0yGJJSxZqdrIQ2BZry2tZa3COk6oPdZ+A++RYVd+PQVLNsNFMfPlz+YsdaWQV8 3mHnHJbDXP8vf77dloAQ6q43VBjMCXepxMrst0GTmUtgics4M3b4YsJNeycrrJZUM5Qz mAdTnX/o+Duku4LqfFR34vbyjHYPjxIpW7sBGc1Eet99H6RajPD4lMbQfruCKJOBXN5G sB2UFGzQugUs5xojtTwkqJF+3sjfGMiHR69OxghqKVkML9qWYKJZDe3EkZM3xLsSIcI4 NXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vEa8wOAy1yjkPGX5niq7cKlzEqEbn5vgGX01uFZeyx0=; b=5vFid8GigkJ5F+XG39D1PWKyZdOeKs78ACXpkaWv2OEHuvS0YU7JwdvxqehWdbHAMC R0Smk5W75cHLEOEQYZcQ2c8pIMQedNxlXYlJhCLkzC6H8Z07nrvEdKusFymDs0B+2WvO Rh8AdNimQFGUCFs0WwBKL0CxZuUqAjuxYuN6JrHAAPy8Dx6c7UrqttciKTro2cP6Io6K t2mSHu2SOlvymVRm+iTq9lAVDuBkni5JMUcZhYTwtepPeFUmWJd3dEwzU0OINUhCFDFJ wRukI8zwkIqDQrBqWADpYzTuycM3wua2HOw0sOkJS84pF2QzwDIoFB1HqMAWwK9Yn9Ud krMQ== X-Gm-Message-State: AOAM531xtyZ/JLOJDSWAYi6SuHlWxaSFMqDy4qfdpqsZ3wbpS2jS2Zog ajKhBW0SvHR2QSHhU9wSqJxHJWg0IK/bWQ98B35sMho9 X-Google-Smtp-Source: ABdhPJylF+Cpre/GiNn3g19TPGrcInAvsIOw3/g+SromJnXzeeMISXrmlBvn+4RN1atdrpxe1dwbke3HGSoWnNXtBmc= X-Received: by 2002:a67:f745:0:b0:335:e652:c692 with SMTP id w5-20020a67f745000000b00335e652c692mr4980498vso.52.1653084301990; Fri, 20 May 2022 15:05:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrii Nakryiko Date: Fri, 20 May 2022 15:04:47 -0700 Message-ID: Subject: Re: [PATCH v3 bpf-next 5/5] selftests/bpf: add selftest for bpf_xdp_ct_add and bpf_ct_refresh_timeout kfunc To: Lorenzo Bianconi Cc: bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "David S. Miller" , Jakub Kicinski , Eric Dumazet , pabeni@redhat.com, Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org, Lorenzo Bianconi , Jesper Dangaard Brouer , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Kumar Kartikeya Dwivedi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 18, 2022 at 3:44 AM Lorenzo Bianconi wrote: > > Introduce selftests for the following kfunc helpers: > - bpf_xdp_ct_add > - bpf_skb_ct_add > - bpf_ct_refresh_timeout > > Signed-off-by: Lorenzo Bianconi > --- > .../testing/selftests/bpf/prog_tests/bpf_nf.c | 4 ++ > .../testing/selftests/bpf/progs/test_bpf_nf.c | 72 +++++++++++++++---- > 2 files changed, 64 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c > index dd30b1e3a67c..be6c5650892f 100644 > --- a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c > +++ b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c > @@ -39,6 +39,10 @@ void test_bpf_nf_ct(int mode) > ASSERT_EQ(skel->bss->test_enonet_netns_id, -ENONET, "Test ENONET for bad but valid netns_id"); > ASSERT_EQ(skel->bss->test_enoent_lookup, -ENOENT, "Test ENOENT for failed lookup"); > ASSERT_EQ(skel->bss->test_eafnosupport, -EAFNOSUPPORT, "Test EAFNOSUPPORT for invalid len__tuple"); > + ASSERT_EQ(skel->bss->test_add_entry, 0, "Test for adding new entry"); > + ASSERT_EQ(skel->bss->test_succ_lookup, 0, "Test for successful lookup"); > + ASSERT_TRUE(skel->bss->test_delta_timeout > 9 && skel->bss->test_delta_timeout <= 10, > + "Test for ct timeout update"); if/when this fails we'll have "true != false" message not knowing what was the actual value of skel->bss->test_delta_timeout. This is equivalent to a much better: ASSERT_GT(skel->bss->test_delta_timeout, 9, "ct_timeout1"); ASSERT_LE(skel->bss->test_delta_timeout, 10, "ct_timeout2"); > end: > test_bpf_nf__destroy(skel); > } [...]