From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E95C43460 for ; Wed, 31 Mar 2021 19:03:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C0EF61077 for ; Wed, 31 Mar 2021 19:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235864AbhCaTDR (ORCPT ); Wed, 31 Mar 2021 15:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235355AbhCaTCy (ORCPT ); Wed, 31 Mar 2021 15:02:54 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CBF6C061574; Wed, 31 Mar 2021 12:02:54 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id i144so22295716ybg.1; Wed, 31 Mar 2021 12:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4YJuvsy/+GmcZTEa0tdVi7R2ikqrBhX1iPZvjApLAs=; b=eh6miJHWMN67GvZJKMUUlqC/vt5HffuuJekrIXqnOFja9szLbtMyRO2kQ460axt5em voPwdMMQ3q0ES1q7EpvecsLeEmghddOhd0LySWDFG37IUR5V3YSgFq9SVDFWFjLMs5Wl 5fY1Jd7i7xv650MK/jcIsoBAWbRncrPdNEXAGBg8gH8Tj7Cv3AnsMlHnY3Ty0MtvAz5h aKulvk61B21qI3rxwRL39Ln4W89Cw+eY5SJItZtc1/XfIihM/wseanCoGxjbXYcHlnTG +cGAl7Tf0Clek2mGcqnr+MHuGwB1WMD3KX1huwbPC/NKnwfxIA9mfwVp2fxi6TPhEeq1 gMxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x4YJuvsy/+GmcZTEa0tdVi7R2ikqrBhX1iPZvjApLAs=; b=d1J9T1nE03qfTxf/pR0jArl/+hUqI0J7kwKBz/Xazlz/uKpau3sm4wAY1BRqZUq9Bw zAqBuTbeJ4tlMuF7j/J0jFTLsxuF/uPkkihmnI/EiZ06JiNuRgh00VI7hQK+irYrM7aM 2h55kmHKEMX9NW+kdFQxFfozRgAMUbrRKVsKQwu4OvCvdsNngq9BBKYSExgk4V9VIvpA eID4t3TTB4kPTXV2EG5NXqw19w5XX3oX4ukl5xExW3bC2Q77cMyGLjgoN7/uGK7TEEgk xMnJig5DRnsEE3gphnrPgxJryvw9tPgw9wzSQe0B5liWs1yZby2v+ehD6/mOg43w6BrW Gd3g== X-Gm-Message-State: AOAM532IrP8bpfrATz7ZCZ4b3h1HM0DjkuSWLFyGnyFOQ/SILD0qWDLh DMlVp2CWqG4T5FfZrK6CVGXQlkpxufwx/458iuQ= X-Google-Smtp-Source: ABdhPJwoyy0ZYnVd7MLaLqauT7nPJ6FBJnNpTBaiWgC42URXaos//I5E6tR5+2lkl7HE7aazVbTzr7Dv4aKh9XbhEeQ= X-Received: by 2002:a25:5b55:: with SMTP id p82mr6243094ybb.510.1617217373404; Wed, 31 Mar 2021 12:02:53 -0700 (PDT) MIME-Version: 1.0 References: <20210330020656.26bb2dfd@xhacker> In-Reply-To: <20210330020656.26bb2dfd@xhacker> From: Andrii Nakryiko Date: Wed, 31 Mar 2021 12:02:42 -0700 Message-ID: Subject: Re: [PATCH] selftests/bpf: add LDFLAGS when building test_verifier To: Jisheng Zhang Cc: Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "open list:KERNEL SELFTEST FRAMEWORK" , Networking , bpf , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 29, 2021 at 11:11 AM Jisheng Zhang wrote: > > From: Jisheng Zhang > > This is useful for cross compile process to point linker to the > correct libelf, libcap, libz path. Is this enough to make cross-compilation of selftests/bpf work? I think there was a discussion another day about cross-compiling selftests/bpf, so I wonder if this is the only change that's needed to make it work. > > Signed-off-by: Jisheng Zhang > --- > tools/testing/selftests/bpf/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 044bfdcf5b74..dac1c5094e28 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -447,7 +447,7 @@ verifier/tests.h: verifier/*.c > ) > verifier/tests.h) > $(OUTPUT)/test_verifier: test_verifier.c verifier/tests.h $(BPFOBJ) | $(OUTPUT) > $(call msg,BINARY,,$@) > - $(Q)$(CC) $(CFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@ > + $(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(filter %.a %.o %.c,$^) $(LDLIBS) -o $@ > > # Make sure we are able to include and link libbpf against c++. > $(OUTPUT)/test_cpp: test_cpp.cpp $(OUTPUT)/test_core_extern.skel.h $(BPFOBJ) > -- > 2.31.0 > >