From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1C5C433DF for ; Tue, 14 Jul 2020 18:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9194225AA for ; Tue, 14 Jul 2020 18:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHMy4vhl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729093AbgGNSjg (ORCPT ); Tue, 14 Jul 2020 14:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgGNSjf (ORCPT ); Tue, 14 Jul 2020 14:39:35 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A64F8C061755; Tue, 14 Jul 2020 11:39:35 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id g13so13615877qtv.8; Tue, 14 Jul 2020 11:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0dgImjyNhW5JDCTf6TF6OJolyi6XBwPEJBCGzeL/cw8=; b=OHMy4vhl7ZxeI3Kl/t3JWx0Xz61kUjwaCm3/rilgo91MGkY2AUHKICMwEyleYYoNLq c1LBrUm7AMEUx9UBVpymALbcT1dT38/9jYjX/TNir7ERKOqwmTepfI6Q+FC/fso8ciTJ 7csvjy2i5Oie9rNwgrxPn5jLpgZkEG+/IsTPACWsebq4YndhTAiVbEj0pLz1tCY0i64G mGCcAZkows7USToi8udEaouXXxYAUs1ueEGwc0Q86Cf6ZTzrESGMDZaHlYR6hHnUR7CM W7m9E/wIYxk17LYpAiCe6T8939EbMUS0C0vwKs4SxPmAk7Ul3KFCc7R1o1uQeYDfHnwV tq2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0dgImjyNhW5JDCTf6TF6OJolyi6XBwPEJBCGzeL/cw8=; b=VAC+eGzIiGQWQvoxWpFMkG0F2w6mGo5hzWWnGzRIWU5e2i7FYzB28KaCRniMxZmqrz wfNqjzlK/3EmLr4vDWYBrN7HeV9o+Fk5mYHVuZK9FKizZaBxRMzxh9kT2NTO9EMNRhyM XSxG6hzwzyp/yur4ZUFBLQc6A0b0Ut8RcRO077hhID4qBTyWJTwawWJ+edJlq7wHdkzu h8aViJABBiBRVP0+QpdSk0GynkudyorcrGfdYTA+myxHo2uaW/TANoxZ/0bLcaJVEYBm KoSLWJ8Da3dSOPQQ3ojXi8wguE/PsR1F1m7qmg5avBxEJc8+2Fs2Ot/j2L+bkDgAaaBO lP8Q== X-Gm-Message-State: AOAM531/2Vj1zf+iURz3SbKy/VcavEhfsKA8VR1wLJe1OSO+MgESBpA+ 5YnZsqxUiCbUy4ohjappn84D23CjtYcyvBv+Ct6xJ3yI X-Google-Smtp-Source: ABdhPJzmeqCamgA/65SC4by2eUPBDMSyjxMhZJLwRc6HH+HaX3N4UhETbmyBlY9bH8tWjbveTowKcjtocbgVzRgfCag= X-Received: by 2002:aed:2cc5:: with SMTP id g63mr6029220qtd.59.1594751974709; Tue, 14 Jul 2020 11:39:34 -0700 (PDT) MIME-Version: 1.0 References: <20200714040643.1135876-4-andriin@fb.com> <202007141403.f8tW3jcQ%lkp@intel.com> In-Reply-To: <202007141403.f8tW3jcQ%lkp@intel.com> From: Andrii Nakryiko Date: Tue, 14 Jul 2020 11:39:23 -0700 Message-ID: Subject: Re: [PATCH v2 bpf-next 3/8] bpf, xdp: add bpf_link-based XDP attachment API To: kernel test robot Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , David Ahern , kbuild-all@lists.01.org, clang-built-linux , Kernel Team , Andrey Ignatov , Takshak Chahande Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 13, 2020 at 11:40 PM kernel test robot wrote: > > Hi Andrii, > > I love your patch! Yet something to improve: > > [auto build test ERROR on bpf-next/master] > > url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/BPF-XDP-link/20200714-120909 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: x86_64-defconfig (attached as .config) > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> net/core/dev.c:8717:18: error: field has incomplete type 'struct bpf_link' > struct bpf_link link; > ^ This is all due to bpf_link-related API is conditionally defined only #ifdef CONFIG_BPF_SYSCALL. I'm doing the same as is done for bpf_prog: moving it outside of CONFIG_BPF_SYSCALL-only region and adding stubs for generic API (init/settle/cleanup, inc/put, etc). Will add this as a separate pre-patch in the v3. > include/net/netns/bpf.h:15:9: note: forward declaration of 'struct bpf_link' > struct bpf_link *links[MAX_NETNS_BPF_ATTACH_TYPE]; > ^ [...]