From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Jiri Olsa <jolsa@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
KP Singh <kpsingh@chromium.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from benchmarks and test_overhead
Date: Wed, 23 Sep 2020 10:40:04 -0700 [thread overview]
Message-ID: <CAEf4Bza8Omo6-f=ndMJiwxNma-G9EK6bnyHxTU0evCi=zSephg@mail.gmail.com> (raw)
In-Reply-To: <160079992560.8301.11225602391403157558.stgit@toke.dk>
On Tue, Sep 22, 2020 at 11:39 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> From: Toke Høiland-Jørgensen <toke@redhat.com>
>
> The benchmark code and the test_overhead prog_test included fmod_ret
> programs that attached to various functions in the kernel. However, these
> functions were never listed as allowed for return modification, so this
> only worked because of the verifier skipping tests when a trampoline
> already existed for the attach point. Now that the verifier checks have
> been fixed, remove fmod_ret from the affected tests so they all work again.
>
> Fixes: 4eaf0b5c5e04 ("selftest/bpf: Fmod_ret prog and implement test_overhead as part of bench")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
Acked-by: Andrii Nakryiko <andriin@fb.com>
> tools/testing/selftests/bpf/bench.c | 5 -----
> tools/testing/selftests/bpf/benchs/bench_rename.c | 17 -----------------
> tools/testing/selftests/bpf/benchs/bench_trigger.c | 17 -----------------
> .../selftests/bpf/prog_tests/test_overhead.c | 14 +-------------
> tools/testing/selftests/bpf/progs/test_overhead.c | 6 ------
> tools/testing/selftests/bpf/progs/trigger_bench.c | 7 -------
> 6 files changed, 1 insertion(+), 65 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-09-23 17:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 18:38 [PATCH bpf-next v8 00/11] bpf: Support multi-attach for freplace programs Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 01/11] bpf: disallow attaching modify_return tracing functions to other BPF programs Toke Høiland-Jørgensen
2020-09-23 17:25 ` Andrii Nakryiko
2020-09-22 18:38 ` [PATCH bpf-next v8 02/11] bpf: change logging calls from verbose() to bpf_log() and use log pointer Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 03/11] bpf: verifier: refactor check_attach_btf_id() Toke Høiland-Jørgensen
2020-09-23 23:54 ` Alexei Starovoitov
2020-09-22 18:38 ` [PATCH bpf-next v8 04/11] bpf: move prog->aux->linked_prog and trampoline into bpf_link on attach Toke Høiland-Jørgensen
2020-09-24 0:14 ` Alexei Starovoitov
2020-09-24 14:34 ` Toke Høiland-Jørgensen
2020-09-24 15:43 ` Alexei Starovoitov
2020-09-24 21:30 ` Toke Høiland-Jørgensen
2020-09-24 20:40 ` Andrii Nakryiko
2020-09-24 21:24 ` Toke Høiland-Jørgensen
2020-09-24 21:59 ` Andrii Nakryiko
2020-09-24 22:20 ` Toke Høiland-Jørgensen
2020-09-24 22:37 ` Andrii Nakryiko
2020-09-24 23:13 ` Toke Høiland-Jørgensen
2020-09-24 21:59 ` Toke Høiland-Jørgensen
2020-09-25 15:45 ` Alexei Starovoitov
2020-09-25 20:57 ` Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 05/11] bpf: support attaching freplace programs to multiple attach points Toke Høiland-Jørgensen
2020-09-24 1:04 ` Alexei Starovoitov
2020-09-22 18:38 ` [PATCH bpf-next v8 06/11] bpf: Fix context type resolving for extension programs Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 07/11] libbpf: add support for freplace attachment in bpf_link_create Toke Høiland-Jørgensen
2020-09-23 17:28 ` Andrii Nakryiko
2020-09-23 20:58 ` Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 08/11] selftests: add test for multiple attachments of freplace program Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 09/11] selftests/bpf: Adding test for arg dereference in extension trace Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 10/11] selftests: Add selftest for disallowing modify_return attachment to freplace Toke Høiland-Jørgensen
2020-09-22 18:38 ` [PATCH bpf-next v8 11/11] selftests: Remove fmod_ret from benchmarks and test_overhead Toke Høiland-Jørgensen
2020-09-23 17:40 ` Andrii Nakryiko [this message]
2020-09-24 1:08 ` Alexei Starovoitov
2020-09-24 1:38 ` Andrii Nakryiko
2020-09-24 23:19 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4Bza8Omo6-f=ndMJiwxNma-G9EK6bnyHxTU0evCi=zSephg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=echaudro@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).