From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5770CC41514 for ; Fri, 16 Aug 2019 05:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D6B52133F for ; Fri, 16 Aug 2019 05:23:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lYK9LS3N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfHPFX1 (ORCPT ); Fri, 16 Aug 2019 01:23:27 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:39669 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfHPFX1 (ORCPT ); Fri, 16 Aug 2019 01:23:27 -0400 Received: by mail-qk1-f196.google.com with SMTP id 125so3795098qkl.6; Thu, 15 Aug 2019 22:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uHyOSrsLg+OpTAnL/CHZKBv938Zif7lAbBDshh9pX/c=; b=lYK9LS3N7wVCkLjV2IsreoUe7z+fSQ9B/mQ08Q3vfdBmDbtZUiYi0wa6QMOZSXWJGI RB2Lc+mK0FrrdoMlT6ptkYsIjxwwNCbc16b4K6kKgiytfPkhEWKpzljzg4L0JYplp0Ao ETAEXJjEe2KA+kSlN9b10R5CNaKIivxG4iAKKQfotYPv0bLjPoAZgxVklWZ3e98qNmra SEWCCfTaEBlGNusKq86KxYTZEzcSGJbLJTPhL0WNeO9RMXJ2Q7gue0fCSusiCBvug4q4 uMNs2Lp3LJtq5jf6jR4TwpZ5exqo1S7by7/bal6Mhlx8nOUvgj/a8+RS1ptYVSHDrofR 4law== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uHyOSrsLg+OpTAnL/CHZKBv938Zif7lAbBDshh9pX/c=; b=AGE64x333SK+w483f4/+Jj8LNUuUfGP80yr0WxdHsp6lERYUZnNeSW3AB3+AnGTHgb BONk7edO18+NFMGV/V8DnCEYadPH8MXs1t5d1JkNHwdxoVh8q6qKQe602it7Vknsu2WI bLL48m+IpSdI9UzKnMIChpqElhrMA1HT6om0152jXSEj+256jukmouwDOExYhVvFPcfu bVmSLb7NHiBjHlcI4RVaVrZsAzKYB+bvnoa2etkUVoeMl6iK5H1hoPWxidQjY97M5Jkc p9bR8aHGhHDEyFdYc6W46XR6y9KU087Cj2abkabyBeCGGSsnVfSryEifQhaD1xss3PEk Wpqg== X-Gm-Message-State: APjAAAWhYq1feGVWXgenVaXxX7vKWpBFRJkGGKYBhdUAanfo/ywWjtxW 4hZj6nugtm8PFVFDnA3IlLcsMIZy1tRVh9BcFvQ= X-Google-Smtp-Source: APXvYqxvHQeKguD98k0XdADD/VXzOjaffIHkuxcXXYHy0FpA90De4BOpFPS7MfUZZ1XksLjDU+lcQvwf79yN3UzAR8E= X-Received: by 2002:a37:9b48:: with SMTP id d69mr7465606qke.449.1565933006557; Thu, 15 Aug 2019 22:23:26 -0700 (PDT) MIME-Version: 1.0 References: <20190814164742.208909-1-sdf@google.com> <20190814164742.208909-3-sdf@google.com> <20190814195330.GL2820@mini-arch> In-Reply-To: From: Andrii Nakryiko Date: Thu, 15 Aug 2019 22:23:15 -0700 Message-ID: Subject: Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip To: Alexei Starovoitov Cc: Stanislav Fomichev , Stanislav Fomichev , Networking , bpf , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 15, 2019 at 10:16 PM Alexei Starovoitov wrote: > > On Wed, Aug 14, 2019 at 1:01 PM Andrii Nakryiko > wrote: > > > > > > Let me know if you see a value in highlighting test vs subtest skip. > > > > > > Other related question is: should we do verbose output in case > > > of a skip? Right now we don't do it. > > > > It might be useful, I guess, especially if it's not too common. But > > Alexei is way more picky about stuff like that, so I'd defer to him. I > > have no problem with a clean "SKIPPED: / (maybe some > > reason for skipping here)" message. > > Since test_progs prints single number for FAILED tests then single number > for SKIPPED tests is fine as well. I'm fine with single number, but it should count number of subtests skipped, if there are subtests within test, same as for FAILED.