From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>,
Networking <netdev@vger.kernel.org>,
Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf] bpf: selftest: Fix flaky tcp_hdr_options test when adding addr to lo
Date: Tue, 13 Oct 2020 14:59:00 -0700 [thread overview]
Message-ID: <CAEf4BzbFoFryfELodTeQPQdC_hR5o9rxCXwNd4y4Tu-xZyV-9A@mail.gmail.com> (raw)
In-Reply-To: <20201012234940.1707941-1-kafai@fb.com>
On Tue, Oct 13, 2020 at 4:13 AM Martin KaFai Lau <kafai@fb.com> wrote:
>
> The tcp_hdr_options test adds a "::eB9F" addr to the lo dev.
> However, this non loopback address will have a race on ipv6 dad
> which may lead to EADDRNOTAVAIL error from time to time.
>
> Even nodad is used in the iproute2 command, there is still a race in
> when the route will be added. This will then lead to ENETUNREACH from
> time to time.
>
> To avoid the above, this patch uses the default loopback address "::1"
> to do the test.
>
> Fixes: ad2f8eb0095e ("bpf: selftests: Tcp header options")
> Reported-by: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> ---
Less shelling out is always good :)
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> .../bpf/prog_tests/tcp_hdr_options.c | 26 +------------------
> .../bpf/progs/test_misc_tcp_hdr_options.c | 2 +-
> 2 files changed, 2 insertions(+), 26 deletions(-)
>
[...]
prev parent reply other threads:[~2020-10-14 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 23:49 [PATCH bpf] bpf: selftest: Fix flaky tcp_hdr_options test when adding addr to lo Martin KaFai Lau
2020-10-13 21:59 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbFoFryfELodTeQPQdC_hR5o9rxCXwNd4y4Tu-xZyV-9A@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).