From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
"linux-perf-use." <linux-perf-users@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCHv2 0/3] perf tools: Fix prologue generation
Date: Tue, 10 May 2022 16:48:55 -0700 [thread overview]
Message-ID: <CAEf4BzbK9zgetgE1yKkCANTZqizUrXgamJa2X0f0XmzQUdFrCQ@mail.gmail.com> (raw)
In-Reply-To: <20220510074659.2557731-1-jolsa@kernel.org>
On Tue, May 10, 2022 at 12:47 AM Jiri Olsa <jolsa@kernel.org> wrote:
>
> hi,
> sending change we discussed some time ago [1] to get rid of
> some deprecated functions we use in perf prologue code.
>
> Despite the gloomy discussion I think the final code does
> not look that bad ;-)
>
> This patchset removes following libbpf functions from perf:
> bpf_program__set_prep
> bpf_program__nth_fd
> struct bpf_prog_prep_result
>
> v2 changes:
> - use fallback section prog handler, so we don't need to
> use section prefix [Andrii]
> - realloc prog->insns array in bpf_program__set_insns [Andrii]
> - squash patch 1 from previous version with
> bpf_program__set_insns change [Daniel]
> - patch 3 already merged [Arnaldo]
> - added more comments
>
> meanwhile.. perf/core and bpf-next diverged, so:
> - libbpf bpf_program__set_insns change is based on bpf-next/master
> - perf changes do not apply on bpf-next/master so they are based on
> perf/core ... however they can be merged only after we release
> libbpf 0.8.0 with bpf_program__set_insns change, so we don't break
> the dynamic linking
> I'm sending perf changes now just for review, I'll resend them
> once libbpf 0.8.0 is released
>
> thanks,
> jirka
>
>
> [1] https://lore.kernel.org/bpf/CAEf4BzaiBO3_617kkXZdYJ8hS8YF--ZLgapNbgeeEJ-pY0H88g@mail.gmail.com/
> ---
> Jiri Olsa (1):
> libbpf: Add bpf_program__set_insns function
>
The first patch looks good to me. The rest I can't really review and
test properly, so I'll leave it up to Arnaldo.
Arnaldo, how do we coordinate these patches? Should they go through
bpf-next (after you Ack them) or you want them in your tree?
I'd like to get the bpf_program__set_insns() patch into bpf-next so
that I can do libbpf v0.8 release, having it in a separate tree is
extremely inconvenient. Please let me know how you think we should
proceed?
> tools/lib/bpf/libbpf.c | 22 ++++++++++++++++++++++
> tools/lib/bpf/libbpf.h | 18 ++++++++++++++++++
> tools/lib/bpf/libbpf.map | 1 +
> 3 files changed, 41 insertions(+)
>
> Jiri Olsa (2):
> perf tools: Register fallback libbpf section handler
> perf tools: Rework prologue generation code
>
> tools/perf/util/bpf-loader.c | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 157 insertions(+), 18 deletions(-)
next prev parent reply other threads:[~2022-05-10 23:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 7:46 [PATCHv2 0/3] perf tools: Fix prologue generation Jiri Olsa
2022-05-10 7:46 ` [PATCHv2 bpf-next 1/3] libbpf: Add bpf_program__set_insns function Jiri Olsa
2022-05-10 7:46 ` [PATCHv2 perf/core 2/3] perf tools: Register fallback libbpf section handler Jiri Olsa
2022-05-10 23:45 ` Andrii Nakryiko
2022-05-11 7:36 ` Jiri Olsa
2022-05-10 7:46 ` [PATCHv2 perf/core 3/3] perf tools: Rework prologue generation code Jiri Olsa
2022-05-10 23:48 ` Andrii Nakryiko [this message]
2022-05-11 7:35 ` [PATCHv2 0/3] perf tools: Fix prologue generation Jiri Olsa
2022-05-11 18:22 ` Arnaldo Carvalho de Melo
2022-05-17 22:02 ` Andrii Nakryiko
2022-05-18 4:45 ` Ian Rogers
2022-05-18 9:48 ` Jiri Olsa
2022-05-18 9:46 ` Jiri Olsa
2022-05-19 11:03 ` Jiri Olsa
2022-05-20 21:46 ` Andrii Nakryiko
2022-05-21 17:44 ` Arnaldo Carvalho de Melo
2022-05-23 7:49 ` Jiri Olsa
2022-05-23 22:43 ` Andrii Nakryiko
2022-05-24 8:28 ` Jiri Olsa
2022-06-01 17:39 ` Andrii Nakryiko
2022-06-01 18:09 ` Jiri Olsa
2022-05-11 12:20 ` patchwork-bot+netdevbpf
2022-05-27 1:16 ` Arnaldo Carvalho de Melo
2022-06-01 18:11 ` Jiri Olsa
2022-06-01 22:21 ` Andrii Nakryiko
2022-06-02 10:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbK9zgetgE1yKkCANTZqizUrXgamJa2X0f0XmzQUdFrCQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).