From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF4AFC432C0 for ; Mon, 2 Dec 2019 17:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92CF220833 for ; Mon, 2 Dec 2019 17:09:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JGT1wvi7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727823AbfLBRJs (ORCPT ); Mon, 2 Dec 2019 12:09:48 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:39597 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbfLBRJr (ORCPT ); Mon, 2 Dec 2019 12:09:47 -0500 Received: by mail-qv1-f65.google.com with SMTP id y8so110641qvk.6; Mon, 02 Dec 2019 09:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fSLpCsC0gIfY0yNpzNg6ZYUHgfqDiFco3xCemoRy4iM=; b=JGT1wvi7Mxpe5wO3iuZdiTBowwcSDL2PV10ehqW5a71+rQ8d6L/dY66/rzqHw0LHX/ c7m+7Pk7qw4vQMyyODN43cp4rn/eWqjSiRitTnp9UuhEV2AiWOxvSjc5fhm8RVH5N2Hy omEoeo4cuGcHsrI8I5WCS0BaJI0NUx9tTmFfyCLj+P9BW+QpohFNsNyxNB24J8OPEg2H W3QtFiQ5u5fixCsExbVo/A/D1FrCl8jd9HQVlCGvvneGeobDxcWpElppYnMMRTj/Ygkv TZUeONnst/mdYNJNa5+95qZ+v8u6J0WK+efkGQd5dgIMli9HQtFFuJNwZB0st2e6ejEU rLdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fSLpCsC0gIfY0yNpzNg6ZYUHgfqDiFco3xCemoRy4iM=; b=qX56gglAEv0ERKkxFSLlDNTbKUUbHkAisR8kvKT7n3J8iYCsompO0TOMR8706NRWS5 m3mSB10B4cOO/AAB2joKYe8APQqNVD/euAE96EUC8XZS4N5YfapFH2Lvt77LE/pKQ7UY hUnI+TZX9lGCFiyvwKfzfqewFJw7eJ5HMdCZccwD7difyIpSOEB3LzknngyBl8dAZ3ch uMiv7/Vato3Gk58K8ugQrS18HWBcAgZC1XdYX3URU5uMiCEx4OqeTpi4v9ViiRUqnHM0 In01SFHN3IrWhHazRUrOIhLu9ewgfoq3h00pmoBa12FYsrVYYIzrgYwI79cPUCcd64Kb OPRQ== X-Gm-Message-State: APjAAAWCU8XqZdnh0neodgWx7xnBBNI9GKLaIqAr/UMZjwjPKOrCwwAm G7uP9cKrdxa79V0yKEl2qB4UKrfwU0M5hTVvrs0= X-Google-Smtp-Source: APXvYqyKT6NO6KDsZ2ei5bKypY+iyosLPbJZy/xkL0hciZw1x+t08E3mYmWD+InttgZD7tNu/S5UBmrc2HpBRhRWSwc= X-Received: by 2002:a05:6214:38c:: with SMTP id l12mr1561456qvy.224.1575306584723; Mon, 02 Dec 2019 09:09:44 -0800 (PST) MIME-Version: 1.0 References: <20191127094837.4045-1-jolsa@kernel.org> In-Reply-To: <20191127094837.4045-1-jolsa@kernel.org> From: Andrii Nakryiko Date: Mon, 2 Dec 2019 09:09:33 -0800 Message-ID: Subject: Re: [PATCH 0/3] perf/bpftool: Allow to link libbpf dynamically To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jesper Dangaard Brouer , Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 27, 2019 at 1:49 AM Jiri Olsa wrote: > > hi, > adding support to link bpftool with libbpf dynamically, > and config change for perf. > > It's now possible to use: > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=3D1 I wonder what's the motivation behind these changes, though? Why is linking bpftool dynamically with libbpf is necessary and important? They are both developed tightly within kernel repo, so I fail to see what are the huge advantages one can get from linking them dynamically. > > which will detect libbpf devel package with needed version, > and if found, link it with bpftool. > > It's possible to use arbitrary installed libbpf: > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=3D1 LIBBPF_DIR=3D/tmp/libbp= f/ > > I based this change on top of Arnaldo's perf/core, because > it contains libbpf feature detection code as dependency. > It's now also synced with latest bpf-next, so Toke's change > applies correctly. > > Also available in: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > libbpf/dyn > > thanks, > jirka > > > --- > Jiri Olsa (2): > perf tools: Allow to specify libbpf install directory > bpftool: Allow to link libbpf dynamically > > Toke H=C3=B8iland-J=C3=B8rgensen (1): > libbpf: Export netlink functions used by bpftool > > tools/bpf/bpftool/Makefile | 40 +++++++++++++++++++++++++++++++++= ++++++- > tools/build/feature/test-libbpf.c | 9 +++++++++ > tools/lib/bpf/libbpf.h | 22 +++++++++++++--------- > tools/lib/bpf/libbpf.map | 7 +++++++ > tools/lib/bpf/nlattr.h | 15 ++++++++++----- > tools/perf/Makefile.config | 27 ++++++++++++++++++++------- > 6 files changed, 98 insertions(+), 22 deletions(-) >