From: Andrii Nakryiko <andrii.nakryiko@gmail.com> To: Stanislav Fomichev <sdf@google.com> Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net> Subject: Re: [PATCH bpf v2] selftests/bpf: bring back c++ include/link test Date: Mon, 2 Dec 2019 14:58:42 -0800 Message-ID: <CAEf4BzbYk3Wd5mPeFRbFCfFZ4sz4E4BcCO48G6LkiACHt9BBXw@mail.gmail.com> (raw) In-Reply-To: <20191202215931.248178-1-sdf@google.com> On Mon, Dec 2, 2019 at 1:59 PM Stanislav Fomichev <sdf@google.com> wrote: > > Commit 5c26f9a78358 ("libbpf: Don't use cxx to test_libpf target") > converted existing c++ test to c. We still want to include and > link against libbpf from c++ code, so reinstate this test back, > this time in a form of a selftest with a clear comment about > its purpose. > > v2: > * -lelf -> $(LDLIBS) (Andrii Nakryiko) > > Fixes: 5c26f9a78358 ("libbpf: Don't use cxx to test_libpf target") > Signed-off-by: Stanislav Fomichev <sdf@google.com> > --- LGTM. Acked-by: Andrii Nakryiko <andriin@fb.com> > tools/lib/bpf/.gitignore | 1 - > tools/lib/bpf/Makefile | 5 +---- > tools/testing/selftests/bpf/.gitignore | 1 + > tools/testing/selftests/bpf/Makefile | 6 +++++- > .../test_libbpf.c => testing/selftests/bpf/test_cpp.cpp} | 0 > 5 files changed, 7 insertions(+), 6 deletions(-) > rename tools/{lib/bpf/test_libbpf.c => testing/selftests/bpf/test_cpp.cpp} (100%) > [...]
next prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-02 21:59 Stanislav Fomichev 2019-12-02 22:58 ` Andrii Nakryiko [this message] 2019-12-05 1:59 ` Alexei Starovoitov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEf4BzbYk3Wd5mPeFRbFCfFZ4sz4E4BcCO48G6LkiACHt9BBXw@mail.gmail.com \ --to=andrii.nakryiko@gmail.com \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=netdev@vger.kernel.org \ --cc=sdf@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Netdev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \ netdev@vger.kernel.org public-inbox-index netdev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.netdev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git