From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0953C64E90 for ; Mon, 30 Nov 2020 22:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C5872076C for ; Mon, 30 Nov 2020 22:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r2WmhiZU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729573AbgK3Wxi (ORCPT ); Mon, 30 Nov 2020 17:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729586AbgK3Wxi (ORCPT ); Mon, 30 Nov 2020 17:53:38 -0500 Received: from mail-yb1-xb43.google.com (mail-yb1-xb43.google.com [IPv6:2607:f8b0:4864:20::b43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 775D3C061A47; Mon, 30 Nov 2020 14:52:52 -0800 (PST) Received: by mail-yb1-xb43.google.com with SMTP id r127so11665yba.10; Mon, 30 Nov 2020 14:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IVgiVGcuNuLwHmczlMBs6+awdTDl4qx6/4oj/Vf0ZOo=; b=r2WmhiZUBU55p7jVxU+lf6rjdNCdyj4qXLtVW/ObknkmYmyRL7x05PjzevdD1p4c/O ohqsuZDRbOxLioy+qwF+18DnL4WFbPD1XSiVgQ3U1tJgCB7sQnMdV2KmQ41IKNXHRgNd uNP1+82a+58xWV2uWsJ4yG5G2nhWrvEtayHFzFtwghNVzTdCIK0KioOCWVfPLM+qvKbF SaZsR/w6l5/v0day/LS0UkHRO7DvrJwyL6lYxgGEiWgwqHMBrp60MA4UJZW6eqOW5iKe YCaR+t2RrjeNJf+MQbMygWdn0xuaA0M39HreguO7e206Orn+e/UEq7GYOmYSIkmyU6xZ 7r+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IVgiVGcuNuLwHmczlMBs6+awdTDl4qx6/4oj/Vf0ZOo=; b=avO11K8twXUtMxOH5A0pQ9ud4pwmMVLyFsnkwCiRWk9zjtDNLx3Z603/3nZ7MdR/Rc 6edLnU7yNOpmfP5Y8fjrF4pM+PBxuMSL6+DW64dz+o9TkxPwhME4yYeCRhv/BsL/Fkx6 xw+kJKHHFAP/3QfH4ouKa/1wrlNIiQNRnKBMQoo1nP3rjLHn3qp1LbTkc1zA+Ipc0Xt2 GM1fUXsJfM48WvPY3gB+b+aTbgppz4CYmrM/xvnKbsEwfk2C/rMdogDehyvgz94QJL2s FE7nuFdrDBkQGQOsmc8xkXSlIeipTdfnDIqNLl8zsnyP/nRbOsj61JQHDHz2Qg/0x9Ge dSAQ== X-Gm-Message-State: AOAM533jbP9+VCHRd58A4vGZKsevOcsi4Qs/2zf8xskoYe469VLGtXme pvT3LsrlyjYydQHKZVvnaRjaZbaKVBYobDwJzZE= X-Google-Smtp-Source: ABdhPJzVGG9XFN1lNFA00oqPdrdnmZG7QpgAidDjQfn/SZdgDDb/6l3upaskp9jSWIOKjrHEw1F0KFH5n5VVwEfiE88= X-Received: by 2002:a25:2845:: with SMTP id o66mr37749996ybo.260.1606776771766; Mon, 30 Nov 2020 14:52:51 -0800 (PST) MIME-Version: 1.0 References: <20201121024616.1588175-1-andrii@kernel.org> <20201121024616.1588175-6-andrii@kernel.org> <20201129015934.qlikfg7czp4cc7sf@ast-mbp> In-Reply-To: <20201129015934.qlikfg7czp4cc7sf@ast-mbp> From: Andrii Nakryiko Date: Mon, 30 Nov 2020 14:52:41 -0800 Message-ID: Subject: Re: [PATCH bpf-next 5/7] selftests/bpf: add tp_btf CO-RE reloc test for modules To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Nov 28, 2020 at 5:59 PM Alexei Starovoitov wrote: > > On Fri, Nov 20, 2020 at 06:46:14PM -0800, Andrii Nakryiko wrote: > > > > SEC("raw_tp/bpf_sidecar_test_read") > > -int BPF_PROG(test_core_module, > > +int BPF_PROG(test_core_module_probed, > > struct task_struct *task, > > struct bpf_sidecar_test_read_ctx *read_ctx) > > { > > @@ -64,3 +64,33 @@ int BPF_PROG(test_core_module, > > > > return 0; > > } > > + > > +SEC("tp_btf/bpf_sidecar_test_read") > > +int BPF_PROG(test_core_module_direct, > > + struct task_struct *task, > > + struct bpf_sidecar_test_read_ctx *read_ctx) > > "sidecar" is such an overused name. How about "sidekick"? :) Its definition matches quite closely for what we are doing with it ("person's assistant or close associate, especially one who has less authority than that person.")? But if you still hate it, I can call it just "bpf_selftest" or "bpf_test" or "bpf_testmod", however boring that is... ;) > I didn't like it earlier, but seeing that it here again and again I couldn't help it. > Could you please pick a different name for kernel module? > It's just a kernel module for testing. Just call it so. No need for fancy name.