From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7CDC43613 for ; Fri, 21 Jun 2019 17:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 134F52070B for ; Fri, 21 Jun 2019 17:13:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p5YERf40" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726108AbfFURNr (ORCPT ); Fri, 21 Jun 2019 13:13:47 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41589 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfFURNr (ORCPT ); Fri, 21 Jun 2019 13:13:47 -0400 Received: by mail-wr1-f66.google.com with SMTP id c2so7297208wrm.8 for ; Fri, 21 Jun 2019 10:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qxEeJzLHY0AeUcloFKyhFKP9J1yDvwDSvarBW0sLpWk=; b=p5YERf40iErVwSZIGOYNWLyxjEuRXNvD/C2U5Y+E51jvy3Rq/RKLLwPOdqeoC2lL6B tVbknWqPGSwqGmNBSCWCUa8F7rKWJbV1a7DPqZHvI8boVpM+e7aFH/S7NoKXpTHxUCZJ wNekLDjNPqeAZEmYlsvzdXVAozPX/u9XiQnp7EUSdNG38yquIJMQMcKZMaOXeqaNa5F1 0yEQ9T5nVIQa43R+17s5rBS9JgXCTWJAbXEpuPzUK8ewJrtKe1vMCxAnVT02hs2z0DU4 /jv8AY43RGiCYPlt0ozbf+kq01jnXv3cNkg9piIzxT217H0mYYA9YkTrZ9sG0dJqbHN1 GWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qxEeJzLHY0AeUcloFKyhFKP9J1yDvwDSvarBW0sLpWk=; b=athN6BzaXtzNNDu1nNJA8VgdTdBsMBjzkqfPA9QMPdGZArgAiy8MN9L4FiNnzU9foR 2IAsVRFjpjl964c9rVySRg2bzLU7M1AIfKjBKA+ttogPGNgZPV3DqfWsAGOHP0Jx9ybj HqLSduNA9GUpCeG9HQhmIJtGwXbr+gZT4wQyfdPh/RxJO4gZ/pWEqZJFwgwU06lHa0iN jPZZSgl/0YaKeMR72mRTdpH+xXDFrHvaV19DhHzX30BPzuzqZOHA/5g8NgJcWzbLNQN+ JlJD+jD9yVkdcs5n1o3oguX2+uN+Z14cWRitcCJxq393hpTCqaO+OHjJAWlV86SuARrq GXMw== X-Gm-Message-State: APjAAAX+sG9Rl6B/Z7YzKTbywXrPzQCqY8icsULk6qYRlTvNmqhMlf5m bA0pjA1JO4fhyP3NFN+XpS7xFKdECwvVyPqTnS2l X-Google-Smtp-Source: APXvYqwAeQ+zEBR2/g5pAVKTpbJ9LVgSg5JtBVMrUMNnV3DXee1zuaDai4mk8y32FoPD80tF0FRkNZK7YSifRRNDIaU= X-Received: by 2002:a5d:5702:: with SMTP id a2mr55706240wrv.89.1561137226363; Fri, 21 Jun 2019 10:13:46 -0700 (PDT) MIME-Version: 1.0 References: <20190621163921.26188-1-puranjay12@gmail.com> <20190621163921.26188-4-puranjay12@gmail.com> In-Reply-To: <20190621163921.26188-4-puranjay12@gmail.com> From: Bjorn Helgaas Date: Fri, 21 Jun 2019 12:13:34 -0500 Message-ID: Subject: Re: [PATCH 3/3] net: ethernet: atheros: atlx: Remove unused and private PCI definitions To: Puranjay Mohan Cc: Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Linux PCI Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 21, 2019 at 11:40 AM Puranjay Mohan wrote: > > Remove unused private PCI definitions from skfbi.h because generic PCI > symbols are already included from pci_regs.h. > > Signed-off-by: Puranjay Mohan > --- > drivers/net/ethernet/atheros/atlx/atl2.h | 2 -- > drivers/net/ethernet/atheros/atlx/atlx.h | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/atheros/atlx/atl2.h b/drivers/net/ethernet/atheros/atlx/atl2.h > index c53b810a831d..1b25d6d747de 100644 > --- a/drivers/net/ethernet/atheros/atlx/atl2.h > +++ b/drivers/net/ethernet/atheros/atlx/atl2.h > @@ -32,7 +32,6 @@ > int ethtool_ioctl(struct ifreq *ifr); > #endif > > -#define PCI_COMMAND_REGISTER PCI_COMMAND > #define CMD_MEM_WRT_INVALIDATE PCI_COMMAND_INVALIDATE > > #define ATL2_WRITE_REG(a, reg, value) (iowrite32((value), \ > @@ -202,7 +201,6 @@ static void atl2_force_ps(struct atl2_hw *hw); > #define MII_DBG_DATA 0x1E > > /* PCI Command Register Bit Definitions */ > -#define PCI_COMMAND 0x04 > #define CMD_IO_SPACE 0x0001 > #define CMD_MEMORY_SPACE 0x0002 > #define CMD_BUS_MASTER 0x0004 These bit definitions (CMD_IO_SPACE, CMD_MEMORY_SPACE, etc) are also generic PCI things that should be replaced with PCI_COMMAND_IO, PCI_COMMAND_MEMORY, etc. I haven't looked at the file, but there are likely more.