* [PATCH] ipvlan: set hw_enc_features like macvlan
@ 2019-08-15 0:10 Bill Sommerfeld
2019-08-16 1:03 ` Mahesh Bandewar (महेश बंडेवार)
2019-08-16 22:58 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Bill Sommerfeld @ 2019-08-15 0:10 UTC (permalink / raw)
To: David S. Miller, Petr Machata
Cc: Jiri Pirko, Ido Schimmel, Daniel Borkmann, YueHaibing,
Thomas Gleixner, Miaohe Lin, Eric Dumazet, Mahesh Bandewar,
netdev, linux-kernel, Bill Sommerfeld
Allow encapsulated packets sent to tunnels layered over ipvlan to use
offloads rather than forcing SW fallbacks.
Since commit f21e5077010acda73a60 ("macvlan: add offload features for
encapsulation"), macvlan has set dev->hw_enc_features to include
everything in dev->features; do likewise in ipvlan.
Signed-off-by: Bill Sommerfeld <wsommerfeld@google.com>
---
drivers/net/ipvlan/ipvlan_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 1c96bed5a7c4..887bbba4631e 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -126,6 +126,7 @@ static int ipvlan_init(struct net_device *dev)
(phy_dev->state & IPVLAN_STATE_MASK);
dev->features = phy_dev->features & IPVLAN_FEATURES;
dev->features |= NETIF_F_LLTX | NETIF_F_VLAN_CHALLENGED;
+ dev->hw_enc_features |= dev->features;
dev->gso_max_size = phy_dev->gso_max_size;
dev->gso_max_segs = phy_dev->gso_max_segs;
dev->hard_header_len = phy_dev->hard_header_len;
--
2.23.0.rc1.153.gdeed80330f-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipvlan: set hw_enc_features like macvlan
2019-08-15 0:10 [PATCH] ipvlan: set hw_enc_features like macvlan Bill Sommerfeld
@ 2019-08-16 1:03 ` Mahesh Bandewar (महेश बंडेवार)
2019-08-16 22:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mahesh Bandewar (महेश बंडेवार) @ 2019-08-16 1:03 UTC (permalink / raw)
To: Bill Sommerfeld
Cc: David S. Miller, Petr Machata, Jiri Pirko, Ido Schimmel,
Daniel Borkmann, YueHaibing, Thomas Gleixner, Miaohe Lin,
Eric Dumazet, linux-netdev, linux-kernel
On Wed, Aug 14, 2019 at 5:10 PM Bill Sommerfeld <wsommerfeld@google.com> wrote:
>
> Allow encapsulated packets sent to tunnels layered over ipvlan to use
> offloads rather than forcing SW fallbacks.
>
> Since commit f21e5077010acda73a60 ("macvlan: add offload features for
> encapsulation"), macvlan has set dev->hw_enc_features to include
> everything in dev->features; do likewise in ipvlan.
>
Thanks Bill
> Signed-off-by: Bill Sommerfeld <wsommerfeld@google.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
> ---
> drivers/net/ipvlan/ipvlan_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 1c96bed5a7c4..887bbba4631e 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -126,6 +126,7 @@ static int ipvlan_init(struct net_device *dev)
> (phy_dev->state & IPVLAN_STATE_MASK);
> dev->features = phy_dev->features & IPVLAN_FEATURES;
> dev->features |= NETIF_F_LLTX | NETIF_F_VLAN_CHALLENGED;
> + dev->hw_enc_features |= dev->features;
> dev->gso_max_size = phy_dev->gso_max_size;
> dev->gso_max_segs = phy_dev->gso_max_segs;
> dev->hard_header_len = phy_dev->hard_header_len;
> --
> 2.23.0.rc1.153.gdeed80330f-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipvlan: set hw_enc_features like macvlan
2019-08-15 0:10 [PATCH] ipvlan: set hw_enc_features like macvlan Bill Sommerfeld
2019-08-16 1:03 ` Mahesh Bandewar (महेश बंडेवार)
@ 2019-08-16 22:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-08-16 22:58 UTC (permalink / raw)
To: wsommerfeld
Cc: petrm, jiri, idosch, daniel, yuehaibing, tglx, linmiaohe,
edumazet, maheshb, netdev, linux-kernel
From: Bill Sommerfeld <wsommerfeld@google.com>
Date: Wed, 14 Aug 2019 17:10:43 -0700
> Allow encapsulated packets sent to tunnels layered over ipvlan to use
> offloads rather than forcing SW fallbacks.
>
> Since commit f21e5077010acda73a60 ("macvlan: add offload features for
> encapsulation"), macvlan has set dev->hw_enc_features to include
> everything in dev->features; do likewise in ipvlan.
>
> Signed-off-by: Bill Sommerfeld <wsommerfeld@google.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-16 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 0:10 [PATCH] ipvlan: set hw_enc_features like macvlan Bill Sommerfeld
2019-08-16 1:03 ` Mahesh Bandewar (महेश बंडेवार)
2019-08-16 22:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).