From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226E8C433DB for ; Fri, 5 Feb 2021 16:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C129A64F33 for ; Fri, 5 Feb 2021 16:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbhBEOVx (ORCPT ); Fri, 5 Feb 2021 09:21:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232507AbhBEOSz (ORCPT ); Fri, 5 Feb 2021 09:18:55 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8876C0611C1 for ; Fri, 5 Feb 2021 07:48:51 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id d3so10468282lfg.10 for ; Fri, 05 Feb 2021 07:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8XkotKFDqQOyXbEZ+m5tJTrC5sC9MqL0W0IoLPIVHHY=; b=CBa/yyqmn0u3mvFlypZQXERTMmoBJ8kbm6pTQZfhwAKMgH23Q+XHueUC4uOvlXv4vA VXwzTKbhH7NR50L8z6QR7sQZF9Xx4jc3U26syshQx7bSJo5GWHuKv2a/IwAbEgptlRp1 HROcvKzMKABxroasMUTh/9wujSu4q6RoVVLZFwuQFQsFsqr3GOR9QTVutvbINTC2ynL7 iWDqdpLmoASh1N+WD4cFxL7/XrNDZrdhAcUEDlrfod0/uLL2HqPpgGqE1PNWAp1/1JDf GGIa9wlN8EMzHsmftFw1QvQi2EZyDigT8KRwDCGmWMcbaCF6cBHjfjJqHp64WYsCaUXo umIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8XkotKFDqQOyXbEZ+m5tJTrC5sC9MqL0W0IoLPIVHHY=; b=tsz1n4LIf2HJ7XkXH/e/VGoc/+lUvuRnupF9X/PdND/4iM4Xl7vnmfzg9bS1986Laz sW12EabBjF+B6cOmtJ4gVoJ8Rs4qWEcOFHr6WUbIvFP+7dvCpXbfDQy8Xq5lmsJhIFFl ERzLzDjXqv1whSnXy1y1BxvVlk2oahqy5MoJpXU52aRhLeex5LCjGsgnwYQcA1XHuVbJ uGBbIGqlRP1laKYo95dZ7NJGICkLGufeEahQJZ4oRSxK19fSasxhpJ2VdmTO+5K+2x0h nXVHEevb/CoGAl9cDBOdlP8YhK3mdbUjzF2Kt6SkxcDmIDcgrnJzlj7H+zBwCYNY9W3b xl+w== X-Gm-Message-State: AOAM533sTYptlB3HfwWFVSSWVJ+6d7dqmzsN7mj6oSESKWDc5e775sPf TjK3njd6XrJa6wBBrwoaLlXv5fJ9bsIW/ISZEujA8YiA X-Google-Smtp-Source: ABdhPJz2V2JASdMXpFnatx0x5q3KZC/BSz03mrdVB3MjUQ4Le1cnnXV9h9vCQ2YSxr2vtZweVW5pZoiivzsLctUn38w= X-Received: by 2002:a17:906:158c:: with SMTP id k12mr4637834ejd.119.1612539737346; Fri, 05 Feb 2021 07:42:17 -0800 (PST) MIME-Version: 1.0 References: <20210204101550.21595-1-qiangqing.zhang@nxp.com> <20210204101550.21595-3-qiangqing.zhang@nxp.com> In-Reply-To: From: Willem de Bruijn Date: Fri, 5 Feb 2021 10:41:40 -0500 Message-ID: Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac_resume() To: Joakim Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , David Miller , Jakub Kicinski , Network Development , Andrew Lunn , Florian Fainelli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 4, 2021 at 8:18 PM Joakim Zhang wrote= : > > > > -----Original Message----- > > From: Willem de Bruijn > > Sent: 2021=E5=B9=B42=E6=9C=884=E6=97=A5 21:20 > > To: Joakim Zhang > > Cc: Giuseppe Cavallaro ; Alexandre Torgue > > ; Jose Abreu ; David > > Miller ; Jakub Kicinski ; Network > > Development ; Andrew Lunn ; > > Florian Fainelli ; Willem de Bruijn > > > > Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the orde= r of the > > codes in stmmac_resume() > > > > On Thu, Feb 4, 2021 at 5:18 AM Joakim Zhang > > wrote: > > > > > > Slightly adjust the order of the codes in stmmac_resume(), remove the > > > check "if (!device_may_wakeup(priv->device) || !priv->plat->pmt)". > > > > > > Signed-off-by: Joakim Zhang > > > > This commit message says what the code does, but not why or why it's co= rrect. > > This just slight changes the code order, there is no function change, I w= ill improve the commit message if needed. And it is correct to move this phylink initialization before serdes_powerup= ? That is not immediately obvious to me. A comment would definitely be good. More relevant than just stating that the code is moved, which I see from the patch easily.