From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] selftests: fixes for UDP GRO
Date: Tue, 26 Feb 2019 13:38:00 -0500 [thread overview]
Message-ID: <CAF=yD-LeXUVU26iX-di5vfdDvrfuuAcJmyGGpUGN5FHX0fi0Wg@mail.gmail.com> (raw)
In-Reply-To: <2b1f4d9fe21346bc9f85c096e1b0922e4ff3c19d.1551173111.git.pabeni@redhat.com>
On Tue, Feb 26, 2019 at 9:28 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> The current implementation for UDP GRO tests is racy: the receiver
> may flush the RX queue while the sending is still transmitting and
> incorrectly report RX errors, with a wrong number of packet received.
>
> Add explicit timeouts to the receiver for both connection activation
> (first packet received for UDP) and reception completion, so that
> in the above critical scenario the receiver will wait for the
> transfer completion.
>
> Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Willem de Bruijn <willemb@google.com>
---
This is because of that "force termination after the second poll()"?
Could perhaps also just extend do_recv to wait while (!interrupted &&
tnow < tstart + 2000) and avoid the explicit arguments.
next prev parent reply other threads:[~2019-02-26 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:27 [PATCH net] selftests: fixes for UDP GRO Paolo Abeni
2019-02-26 18:38 ` Willem de Bruijn [this message]
2019-02-27 9:26 ` Paolo Abeni
2019-03-01 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-LeXUVU26iX-di5vfdDvrfuuAcJmyGGpUGN5FHX0fi0Wg@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).