From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: Network Development <netdev@vger.kernel.org>,
Petr Vorel <pvorel@suse.cz>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY
Date: Mon, 18 Feb 2019 11:04:40 -0500 [thread overview]
Message-ID: <CAF=yD-LfPvX--7Y79LD_8jmnxPh8yK8fEukhVNA+HBpR6e09-w@mail.gmail.com> (raw)
In-Reply-To: <108d9d95-98f4-74b3-f86c-fbd641e1b67b@oracle.com>
On Mon, Feb 18, 2019 at 6:35 AM Alexey Kodanev
<alexey.kodanev@oracle.com> wrote:
>
> On 15.02.2019 19:58, Willem de Bruijn wrote:
> > On Fri, Feb 15, 2019 at 11:51 AM Alexey Kodanev
> > <alexey.kodanev@oracle.com> wrote:
> >>
> >> For unsupported protocols, setsockopt() with SO_ZEROCOPY
> >> option sets errno to ENOTSUPP(524). But this number is
> >> not defined anywhere in the include/uapi/ headers.
> >>
> >> To make sure userspace sees the known number, replace
> >> ENOTSUPP(524) with EOPNOTSUPP(95).
> >>
> >> Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt")
> >> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> >> Reported-by: Petr Vorel <pvorel@suse.cz>
> >
> > This code has been there since 4.14. I think it's too late to change
> > system call behavior.
> >
>
> 'ENOTSUPP' define is solely for an internal usage, it may be replaced
> with another one or the number associated with it may be changed one day,
> implicitly changing the behavior of setsockopt().
I understand, and this was an error on my part.
But I'm afraid that it is already used by other interfaces, as well.
And indeed in that capacity expected by tests. See for instance
tools/testing/selftests/bpf/test_sock_addr.c
prev parent reply other threads:[~2019-02-18 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 16:52 [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY Alexey Kodanev
2019-02-15 16:58 ` Willem de Bruijn
2019-02-15 21:44 ` Petr Vorel
2019-02-18 11:35 ` Alexey Kodanev
2019-02-18 16:04 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-LfPvX--7Y79LD_8jmnxPh8yK8fEukhVNA+HBpR6e09-w@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=alexey.kodanev@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).