From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, joabreu@synopsys.com,
alexandre.torgue@st.com, peppe.cavallaro@st.com,
khilman@baylibre.com
Subject: Re: [PATCH net-next v1] net: stmmac: initialize the reset delay array
Date: Tue, 18 Jun 2019 23:08:30 +0200 [thread overview]
Message-ID: <CAFBinCB8OHC+2KqP6ufceTSPDbSWH8dg1RuqWHAeqy2tR3k=5Q@mail.gmail.com> (raw)
In-Reply-To: <20190618203927.5862-1-martin.blumenstingl@googlemail.com>
On Tue, Jun 18, 2019 at 10:39 PM Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Commit ce4ab73ab0c27c ("net: stmmac: drop the reset delays from struct
> stmmac_mdio_bus_data") moved the reset delay array from struct
> stmmac_mdio_bus_data to a stack variable.
> The values from the array inside struct stmmac_mdio_bus_data were
> previously initialized to 0 because the struct was allocated using
> devm_kzalloc(). The array on the stack has to be initialized
> explicitly, else we might be reading garbage values.
>
> Initialize all reset delays to 0 to ensure that the values are 0 if the
> "snps,reset-delays-us" property is not defined.
> This fixes booting at least two boards (MIPS pistachio marduk and ARM
> sun8i H2+ Orange Pi Zero). These are hanging during boot when
> initializing the stmmac Ethernet controller (as found by Kernel CI).
> Both have in common that they don't define the "snps,reset-delays-us"
> property.
>
> Fixes: ce4ab73ab0c27c ("net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
to complete what I already wrote as part of the patch description this
issue was:
Reported-by: "kernelci.org bot" <bot@kernelci.org>
next prev parent reply other threads:[~2019-06-18 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 20:39 [PATCH net-next v1] net: stmmac: initialize the reset delay array Martin Blumenstingl
2019-06-18 21:08 ` Martin Blumenstingl [this message]
2019-06-19 21:41 ` David Miller
2019-06-20 17:07 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCB8OHC+2KqP6ufceTSPDbSWH8dg1RuqWHAeqy2tR3k=5Q@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).