netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: David Miller <davem@davemloft.net>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
	kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel
Date: Fri, 25 Sep 2020 14:19:08 +0200	[thread overview]
Message-ID: <CAFBinCBQ1mx-Pg6kzZoHLp4i_Te5_i5NZWMTF_VqF90LGRWOfA@mail.gmail.com> (raw)
In-Reply-To: <20200923.180140.957870805702877808.davem@davemloft.net>

On Thu, Sep 24, 2020 at 3:01 AM David Miller <davem@davemloft.net> wrote:
>
> From: Hauke Mehrtens <hauke@hauke-m.de>
> Date: Tue, 22 Sep 2020 23:41:12 +0200
>
> > The TX DMA channel data is accessed by the xrx200_start_xmit() and the
> > xrx200_tx_housekeeping() function from different threads. Make sure the
> > accesses are synchronized by acquiring the netif_tx_lock() in the
> > xrx200_tx_housekeeping() function too. This lock is acquired by the
> > kernel before calling xrx200_start_xmit().
> >
> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

> Applied, but...
>
> You posted this really fast after my feedback, so I have to ask if you
> actually functionally tested this patch?
it fixes the following crash for me: [0]


Best regards,
Martin


[0] https://pastebin.com/t1SLz9PH

  reply	other threads:[~2020-09-25 12:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 21:41 [PATCH v2] net: lantiq: Add locking for TX DMA channel Hauke Mehrtens
2020-09-24  1:01 ` David Miller
2020-09-25 12:19   ` Martin Blumenstingl [this message]
2020-09-26 19:30   ` Hauke Mehrtens
2020-11-13 20:54   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFBinCBQ1mx-Pg6kzZoHLp4i_Te5_i5NZWMTF_VqF90LGRWOfA@mail.gmail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=davem@davemloft.net \
    --cc=hauke@hauke-m.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).