From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
vivien.didelot@gmail.com, olteanv@gmail.com,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits
Date: Wed, 7 Apr 2021 20:49:33 +0200 [thread overview]
Message-ID: <CAFBinCCv7vSf1H1ONZYU+fo3kRvShYxzemE3-8DqKUzsFFOUPA@mail.gmail.com> (raw)
In-Reply-To: <98ef4831-27eb-48d4-1421-c6496b174659@gmail.com>
Hello,
On Wed, Apr 7, 2021 at 6:47 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 4/6/2021 5:32 PM, Andrew Lunn wrote:
> >> case PHY_INTERFACE_MODE_RGMII:
> >> case PHY_INTERFACE_MODE_RGMII_ID:
> >> case PHY_INTERFACE_MODE_RGMII_RXID:
> >> case PHY_INTERFACE_MODE_RGMII_TXID:
> >> miicfg |= GSWIP_MII_CFG_MODE_RGMII;
> >> +
> >> + if (phylink_autoneg_inband(mode))
> >> + miicfg |= GSWIP_MII_CFG_RGMII_IBS;
> >
> > Is there any other MAC driver doing this? Are there any boards
> > actually enabling it? Since it is so odd, if there is nothing using
> > it, i would be tempted to leave this out.
>
> Some PHYs (Broadcom namely) support suppressing the RGMII in-band
> signaling towards the MAC, so if the MAC relies on that signaling to
> configure itself based on what the PHY reports this may not work.
point taken. in v2 we'll not set GSWIP_MII_CFG_RGMII_IBS unless
there's someone who can actually test this.
so far I don't know any hardware with Lantiq SoC that uses it
Best regards,
Martin
next prev parent reply other threads:[~2021-04-07 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 20:35 [PATCH RFC net 0/2] lantiq: GSWIP: two more fixes Martin Blumenstingl
2021-04-06 20:35 ` [PATCH RFC net 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling Martin Blumenstingl
2021-04-07 0:25 ` Andrew Lunn
2021-04-07 18:56 ` Martin Blumenstingl
2021-04-07 19:44 ` Andrew Lunn
2021-04-07 20:28 ` Martin Blumenstingl
2021-04-07 23:26 ` Andrew Lunn
2021-04-06 20:35 ` [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits Martin Blumenstingl
2021-04-06 21:09 ` Hauke Mehrtens
2021-04-07 0:32 ` Andrew Lunn
2021-04-07 16:47 ` Florian Fainelli
2021-04-07 18:49 ` Martin Blumenstingl [this message]
2021-04-07 20:04 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCv7vSf1H1ONZYU+fo3kRvShYxzemE3-8DqKUzsFFOUPA@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).