From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7427C47097 for ; Thu, 3 Jun 2021 18:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0DF3613E3 for ; Thu, 3 Jun 2021 18:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbhFCSrl (ORCPT ); Thu, 3 Jun 2021 14:47:41 -0400 Received: from linux.microsoft.com ([13.77.154.182]:44720 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbhFCSrk (ORCPT ); Thu, 3 Jun 2021 14:47:40 -0400 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by linux.microsoft.com (Postfix) with ESMTPSA id B32AA20B8008; Thu, 3 Jun 2021 11:45:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B32AA20B8008 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1622745955; bh=lf8obqIyS2qhtxjR7Mi9MkEGyvvpajHXjSrq3w7AQBw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IqHYoY2eF51K4B1BRfEAgTvALDlLvh9m8WiqDYT7VaLO9gh/L/YLsH1C8E69nqCKD SXIdkxTZ11PHMWxStuJVNllURVLpim1rPcwpjR0Alv9K8BrGhygXgcccEG6/4CjREM /0dKw3pPaAMwpE5rQO6cgIgoojsVFwCfzI82Smds= Received: by mail-pl1-f173.google.com with SMTP id u9so3288044plr.1; Thu, 03 Jun 2021 11:45:55 -0700 (PDT) X-Gm-Message-State: AOAM5308j+KEEJGQ/VfkAM5GiUWH2oNGP/3MmPyl36sdXpYtg3T6U4x6 io7E1NfugESON7BBot7pgNCAdAqfQ0a4sF8S8I0= X-Google-Smtp-Source: ABdhPJyNuPz1nMtiXXYpEZb8kLY8qBLhgAqPuG4EN+LJF+UkcLXA3R73bIhWeQhXNcV1yibM3RwAOyya9JHIqmypciY= X-Received: by 2002:a17:90a:7892:: with SMTP id x18mr643257pjk.39.1622745955243; Thu, 03 Jun 2021 11:45:55 -0700 (PDT) MIME-Version: 1.0 References: <20210521161527.34607-1-mcroce@linux.microsoft.com> <20210521161527.34607-4-mcroce@linux.microsoft.com> In-Reply-To: <20210521161527.34607-4-mcroce@linux.microsoft.com> From: Matteo Croce Date: Thu, 3 Jun 2021 20:45:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling To: netdev@vger.kernel.org, linux-mm@kvack.org Cc: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 21, 2021 at 6:16 PM Matteo Croce wrote: > +bool page_pool_return_skb_page(void *data) > +{ > + struct page_pool *pp; > + struct page *page; > + > + page = virt_to_head_page(data); > + if (unlikely(page->pp_magic != PP_SIGNATURE)) > + return false; > + > + pp = (struct page_pool *)page->pp; > + > + /* Driver set this to memory recycling info. Reset it on recycle. > + * This will *not* work for NIC using a split-page memory model. > + * The page will be returned to the pool here regardless of the > + * 'flipped' fragment being in use or not. > + */ > + page->pp = NULL; > + page_pool_put_full_page(pp, virt_to_head_page(data), false); Here I could just use the cached "page" instead of calling virt_to_head_page() once again. -- per aspera ad upstream