From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7D4C4743F for ; Sun, 6 Jun 2021 01:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E551F611AE for ; Sun, 6 Jun 2021 01:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230108AbhFFCBe (ORCPT ); Sat, 5 Jun 2021 22:01:34 -0400 Received: from linux.microsoft.com ([13.77.154.182]:59942 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbhFFCBd (ORCPT ); Sat, 5 Jun 2021 22:01:33 -0400 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by linux.microsoft.com (Postfix) with ESMTPSA id 482E720B800D; Sat, 5 Jun 2021 18:59:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 482E720B800D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1622944784; bh=v/+GCrGCCiPOlEjb4rq7aCBL9rxGyv3aVds9kZ4ujNQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tRG2p/kKeTFnQgkFuOTQm8B9APLq2o4jNM5EepWHqYsCilVJgn/cP8JibdMPhRuOI 7svObQJAObd9IMJYrCnRqKntzQUbXKb2GPZT+L9ulYr4/wppCIcEr4l1yl0ko4aaTh NmU9SpHKVdZE7huTPXpz64Ap9e28hTwpWVPkLbFQ= Received: by mail-pg1-f177.google.com with SMTP id n12so11007232pgs.13; Sat, 05 Jun 2021 18:59:44 -0700 (PDT) X-Gm-Message-State: AOAM532W0+bWgO8Iip0lpyvhB57vnboz+qL9zS/gDOGEb57zwfxgNQET ZEhtfPmeDMz7zTm8r3eeD/pOAbx+F0lh6NLkgmk= X-Google-Smtp-Source: ABdhPJyJeNJEBI4674XtFMAx5L3S7zmvOKQRlj9lAF8s80MVlfhY8BrtvtRDvcQbfjZyo9n03+RoP71oGOBsqvjqEq8= X-Received: by 2002:a63:1703:: with SMTP id x3mr11946603pgl.421.1622944783737; Sat, 05 Jun 2021 18:59:43 -0700 (PDT) MIME-Version: 1.0 References: <20210604183349.30040-1-mcroce@linux.microsoft.com> <20210604183349.30040-5-mcroce@linux.microsoft.com> In-Reply-To: From: Matteo Croce Date: Sun, 6 Jun 2021 03:59:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v7 4/5] mvpp2: recycle buffers To: Matthew Wilcox Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 4, 2021 at 9:48 PM Matthew Wilcox wrote: > > On Fri, Jun 04, 2021 at 08:33:48PM +0200, Matteo Croce wrote: > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -3997,7 +3997,7 @@ static int mvpp2_rx(struct mvpp2_port *port, struct napi_struct *napi, > > } > > > > if (pp) > > - page_pool_release_page(pp, virt_to_page(data)); > > + skb_mark_for_recycle(skb, virt_to_page(data), pp); > > Does this driver only use order-0 pages? Should it be using > virt_to_head_page() here? or should skb_mark_for_recycle() call > compound_head() internally? This driver uses only order-0 pages. -- per aspera ad upstream