From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055B2C282C0 for ; Sat, 26 Jan 2019 01:34:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBC8921902 for ; Sat, 26 Jan 2019 01:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="ZRYmQQCV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbfAZBeC (ORCPT ); Fri, 25 Jan 2019 20:34:02 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:44504 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfAZBeC (ORCPT ); Fri, 25 Jan 2019 20:34:02 -0500 Received: by mail-vs1-f65.google.com with SMTP id u11so6783063vsp.11 for ; Fri, 25 Jan 2019 17:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XJrZXkYyrN9rzSG4wQtsHpb/eXlEkzOIdVGMJ6B9mPU=; b=ZRYmQQCVeave2I3tOS7Fu/0yzVjEBZ3lUBypJ9/Jvd54CMQUOfKVfxL992VEBMMFzk fBWdn1pv7KV1LT6v7XKbDMNkF/4YmgjdzsOLsGClfCW0sfG9X4ziopy34pULxCGfDoz5 HQiE51w5MiGebwxPr8ORl/sX5hoyv7NsLZHZQr12q4ZFc0LejdKKbHyCTLD8E3yGCPWG /b0eZHrVLCTKCgpxXQyvQUT5uPU/T+LnbSTdBOAp9+dpx9wFZUHG+2+VVM4zD12Wa8b/ kZwkO+NwwQo7QZxcb85tnfQZgskxwb9fhnGxhIu+EvtYJh1s+W5KDzUOaTzx5Otdg9qp Uqfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XJrZXkYyrN9rzSG4wQtsHpb/eXlEkzOIdVGMJ6B9mPU=; b=CjGhBQ2o8eI7oBR5JRFLnjlFBng9IG9gOlPO7mkszyxg0wZpnuZ2M5Tz2ehY7gi4PZ lREJIDUcGpVdmIOEaOu8iH47u4uhta4I8iVVkjzYS03PWtFbYQepan0PjAYnFmGJPrTR tnkxUcC3pyybpACAPHGLJ0eoUoFXVoJDm0bIdOFK9RBuUCyC99CswjzYl5oGNXI4GHok PCjoZht86bgBbg534m8Swu9MYL2LBQwa1tgWlmWohjepfbS8BX3BB8WxbL0v35uOXnn1 wWGaFPLj4n9X0c+Q25oHdRXwZFdWbVQBl4YurLCJhPr8F89B2WdbsPpUA+rfxfLwX7+n uUiw== X-Gm-Message-State: AJcUuke7wQ6ToTEPPspigUhR0FxnlQpEtlnXMjb1Sub87tiNnlfqpzC9 ZHcNtm1F2G/W1dMWuo28i5hOm8UiF2PfBXOJGrj2Sw== X-Google-Smtp-Source: ALg8bN56SbUSJ38A2zYkHS1xPIITNjUF8+/dotHOk2AiWap7c5PkFJMAYnuWcRf3lwhsgz62LFk536g6BOwX+Gc2wmI= X-Received: by 2002:a67:e0d4:: with SMTP id m20mr5636672vsl.182.1548466441470; Fri, 25 Jan 2019 17:34:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jim Wilson Date: Fri, 25 Jan 2019 17:33:50 -0800 Message-ID: Subject: Re: [RFC PATCH 1/3] riscv: set HAVE_EFFICIENT_UNALIGNED_ACCESS To: Palmer Dabbelt Cc: bjorn.topel@gmail.com, Christoph Hellwig , linux-riscv@lists.infradead.org, David Lee , daniel@iogearbox.net, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 25, 2019 at 12:21 PM Palmer Dabbelt wrote: > Jim, would you be opposed to something like this? This looks OK to me. > + builtin_define_with_int_value ("__riscv_tune_misaligned_load_cost", > + riscv_tune_info->slow_unaligned_access ? 1024 : 1); > + builtin_define_with_int_value ("__riscv_tune_misaligned_store_cost", > + riscv_tune_info->slow_unaligned_access ? 1024 : 1); It would be nice to have a better way to compute these values, maybe an extra field in the tune structure, but we can always worry about that later when we need it. Jim