[PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1050 composition

[PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1050 composition

[Daniele Palmas]

This patch adds support for Telit FN980 0x1050 composition

0x1050: tty, adb, rmnet, tty, tty, tty, tty

Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
---
Hi Bjørn,

please find below usb-devices output

T:  Bus=03 Lev=01 Prnt=01 Port=06 Cnt=02 Dev#= 10 Spd=480 MxCh= 0
D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=1bc7 ProdID=1050 Rev=04.14
S:  Manufacturer=Telit Wireless Solutions
S:  Product=FN980m
S:  SerialNumber=270b8241
C:  #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs
I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:  If#= 6 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option

Thanks,
Daniele
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3d77cd402ba9..596428ec71df 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1327,6 +1327,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
 	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
 	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)},	/* Telit LE922A */
+	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)},	/* Telit FN980 */
 	{QMI_FIXED_INTF(0x1bc7, 0x1100, 3)},	/* Telit ME910 */
 	{QMI_FIXED_INTF(0x1bc7, 0x1101, 3)},	/* Telit ME910 dual modem */
 	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
-- 
2.17.1

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1050 composition

[Bjørn Mork]

Daniele Palmas <dnlplm@gmail.com> writes:

> This patch adds support for Telit FN980 0x1050 composition
>
> 0x1050: tty, adb, rmnet, tty, tty, tty, tty

Great!  I must admit I have been a bit curious about this since you
submitted the option patch.  And I'm still curious about what to expect
from X55 modems in general.  There was a lot of discussion about future
modems using PCIe instead of USB etc.  I'd appreciate any info you have
on relative performance, quirks, firmware workarounds etc.  If you are
allowed to share any of it..

Acked-by: Bjørn Mork" <bjorn@mork.no>

> please find below usb-devices output
>
> T:  Bus=03 Lev=01 Prnt=01 Port=06 Cnt=02 Dev#= 10 Spd=480 MxCh= 0

480 Mbps is a bit slow for this device, isn't it? :-)

I assume you've tested with higher bus speeds?  Not that it matters for
this patch.  Just curious again.

> D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1bc7 ProdID=1050 Rev=04.14
> S:  Manufacturer=Telit Wireless Solutions
> S:  Product=FN980m
> S:  SerialNumber=270b8241
> C:  #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs
> I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 6 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>
> Thanks,
> Daniele
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 3d77cd402ba9..596428ec71df 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1327,6 +1327,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
>  	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
>  	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)},	/* Telit LE922A */
> +	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)},	/* Telit FN980 */
>  	{QMI_FIXED_INTF(0x1bc7, 0x1100, 3)},	/* Telit ME910 */
>  	{QMI_FIXED_INTF(0x1bc7, 0x1101, 3)},	/* Telit ME910 dual modem */
>  	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */


Acked-by: Bjørn Mork <bjorn@mork.no>

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1050 composition

[Daniele Palmas]

Il giorno mer 9 ott 2019 alle ore 12:17 Bjørn Mork <bjorn@mork.no> ha scritto:
>
> Daniele Palmas <dnlplm@gmail.com> writes:
>
> > This patch adds support for Telit FN980 0x1050 composition
> >
> > 0x1050: tty, adb, rmnet, tty, tty, tty, tty
>
> Great!  I must admit I have been a bit curious about this since you
> submitted the option patch.  And I'm still curious about what to expect
> from X55 modems in general.  There was a lot of discussion about future
> modems using PCIe instead of USB etc.  I'd appreciate any info you have
> on relative performance, quirks, firmware workarounds etc.  If you are
> allowed to share any of it..
>

I was having issues with my hw sample related to the data connection
setup with rmnet: now I verified that is working properly with basic
tests, so I sent the patch.

I've reports of peak UDP DL throughput in loopback in the range of
6Gbps (not in Linux), more than 6 times the value I had with qmi_wwan
and LM960 (1.1Gbps), where the modem limit was reached.

For the sample I have it's probably a bit early to perform throughput
tests, but it is something that I hope to do in the next weeks.

The PCIe 3 EP 2-lanes mode is declared faster, but it won't be easy to
test it on official kernel releases, since drivers are missing.

The idea is to start with the patchset available at
https://lore.kernel.org/lkml/001601d52148$bd852840$388f78c0$@codeaurora.org/T/,
since it is the only public codebase I could find, but I don't expect
to have something working soon...

> Acked-by: Bjørn Mork" <bjorn@mork.no>
>
> > please find below usb-devices output
> >
> > T:  Bus=03 Lev=01 Prnt=01 Port=06 Cnt=02 Dev#= 10 Spd=480 MxCh= 0
>
> 480 Mbps is a bit slow for this device, isn't it? :-)
>
> I assume you've tested with higher bus speeds?  Not that it matters for
> this patch.  Just curious again.
>

Agree, wrong cable just used for getting the usb-devices output :-) A
better one:

T:  Bus=04 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#=  4 Spd=5000 MxCh= 0
D:  Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs=  1
P:  Vendor=1bc7 ProdID=1050 Rev=04.14
S:  Manufacturer=Telit Wireless Solutions
S:  Product=FN980m

Thanks,
Daniele

> > D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=1bc7 ProdID=1050 Rev=04.14
> > S:  Manufacturer=Telit Wireless Solutions
> > S:  Product=FN980m
> > S:  SerialNumber=270b8241
> > C:  #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> > I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs
> > I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> > I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:  If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:  If#= 6 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> >
> > Thanks,
> > Daniele
> > ---
> >  drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 3d77cd402ba9..596428ec71df 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1327,6 +1327,7 @@ static const struct usb_device_id products[] = {
> >       {QMI_FIXED_INTF(0x2357, 0x0201, 4)},    /* TP-LINK HSUPA Modem MA180 */
> >       {QMI_FIXED_INTF(0x2357, 0x9000, 4)},    /* TP-LINK MA260 */
> >       {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */
> > +     {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */
> >       {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)},    /* Telit ME910 */
> >       {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)},    /* Telit ME910 dual modem */
> >       {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},    /* Telit LE920 */
>
>
> Acked-by: Bjørn Mork <bjorn@mork.no>

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1050 composition

[Jakub Kicinski]

On Wed,  9 Oct 2019 11:07:18 +0200, Daniele Palmas wrote:
> This patch adds support for Telit FN980 0x1050 composition
> 
> 0x1050: tty, adb, rmnet, tty, tty, tty, tty
> 
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>

Applied, thanks!