Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation

[Daniele Palmas <dnlplm@gmail.com>]

Hello Jakub,

Il giorno ven 11 nov 2022 alle ore 18:14 Jakub Kicinski
<kuba@kernel.org> ha scritto:
>
> On Wed,  9 Nov 2022 19:02:48 +0100 Daniele Palmas wrote:
> > +bool rmnet_map_tx_agg_skip(struct sk_buff *skb)
> > +{
> > +     bool is_icmp = 0;
> > +
> > +     if (skb->protocol == htons(ETH_P_IP)) {
> > +             struct iphdr *ip4h = ip_hdr(skb);
> > +
> > +             if (ip4h->protocol == IPPROTO_ICMP)
> > +                     is_icmp = true;
> > +     } else if (skb->protocol == htons(ETH_P_IPV6)) {
> > +             unsigned int icmp_offset = 0;
> > +
> > +             if (ipv6_find_hdr(skb, &icmp_offset, IPPROTO_ICMPV6, NULL, NULL) == IPPROTO_ICMPV6)
> > +                     is_icmp = true;
> > +     }
> > +
> > +     return is_icmp;
> > +}
>
> Why this? I don't see it mention in the commit message or any code
> comment.

This is something I've found in downstream code: with my test setup
and scenario it does not make any difference on the icmp packets
timing (both with or without throughput tests ongoing), but I don't
have access to all the systems for which rmnet is used.

So, I'm not sure if it solves a real issue in other situations.

I can move that out and me or someone else will add it again in case
there will be a real issue to be solved.

Thanks,
Daniele