From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 030F2C433EF for ; Fri, 3 Sep 2021 13:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D95FE61059 for ; Fri, 3 Sep 2021 13:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348494AbhICNzh (ORCPT ); Fri, 3 Sep 2021 09:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235443AbhICNzg (ORCPT ); Fri, 3 Sep 2021 09:55:36 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 374F0C061575 for ; Fri, 3 Sep 2021 06:54:36 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id y144so5820410qkb.6 for ; Fri, 03 Sep 2021 06:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Fi9bNLDhSuf32Na/ilvZJ4ae0s2j/usTZf0dw8/hLEs=; b=pmHbQ5Mn3UmHmoieMtB/idwHiyIJ/qWcga1CEO7VM8yN6DTMhOdWuxmMLmr7f3ulot 9xa3EiDcgBBe5SG+6flLW5+EWMdG346NDC2JvRVk3I2oPIq6U6iAQHKmburFcLWbztA9 teAP57HdjeuO5BB+Hn0MYMJFBNeRIhrEiqVV/EZRDoZ3oYmUkGO8Agvg/VwB27Xpm+O4 FsbFYuV/ojdvYvh4DrTKGKRQO8LNIzVIq54N0fB5vaBgCBvyP71kIWuMs8fnqmHqeAmy BT5OaAuNA/k8bn2omaL4vaLWTLApap+2N0mL9I5f+L71tmEMLe+j/dqNU3sE9I4amk65 fTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Fi9bNLDhSuf32Na/ilvZJ4ae0s2j/usTZf0dw8/hLEs=; b=A9McvVYLUwLnXqhL6QQC0PZZ5w5TWUJwUrC7A3d0sYF7GysbdSB8SNM80ncOWGN3AX dyqLYEPjdRgQR7kfd1glfV0s8Q/3a19zTAHQnobA4QOGfw6r0xCC1uVD3jUuxJAxdeHL eYFFmG4qmyRKy4hBREVqsh6WjuPqVSFAdMH+jZFYLo1xSnzSzbKAG9e04zJ31fbGKPDk D72WSTrx80WqlDGLiQi9AiNWUaNvvdSmGE4i2bJpZLRXSVerq3e8nbibCQVdOQcM6z8U 20HZfaJX26wPOUUPy1pQtcbcOIOgWL9PzlswN8uGros/n4L+k0O/g3NpE/dESunuT+ya 9Rpg== X-Gm-Message-State: AOAM531NMclkgQwggANXSshjoogYyY2F7U7bWByTCM448srACIN9lZcl wvGDTX2AB4l7ss0X4djZcP9yu4yM8P9QIJC+7vWN22lAg3o= X-Google-Smtp-Source: ABdhPJwKHNN2e/CCoHNAB3qBS+SCJJM47AZBBCTp96Qx9iyrbjCnSAtN3eTTxYBw+PJW0LJK+Yynd/IG4pUCNoZuIfk= X-Received: by 2002:a05:620a:11ab:: with SMTP id c11mr3519888qkk.169.1630677275288; Fri, 03 Sep 2021 06:54:35 -0700 (PDT) MIME-Version: 1.0 References: <77b850933d9af8ddbc21f5908ca0764d@codeaurora.org> <13972ac97ffe7a10fd85fe03dc84dc02@codeaurora.org> <87bl6aqrat.fsf@miraculix.mork.no> <2c2d1204842f457bb0d0b2c4cd58847d@codeaurora.org> <87sfzlplr2.fsf@miraculix.mork.no> <394353d6f31303c64b0d26bc5268aca7@codeaurora.org> <7aac9ee90376e4757e5f2ebc4948ebed@codeaurora.org> <87tujtamk5.fsf@miraculix.mork.no> In-Reply-To: <87tujtamk5.fsf@miraculix.mork.no> From: Daniele Palmas Date: Fri, 3 Sep 2021 15:55:00 +0200 Message-ID: Subject: Re: RMNET QMAP data aggregation with size greater than 16384 To: =?UTF-8?Q?Bj=C3=B8rn_Mork?= Cc: Subash Abhinov Kasiviswanathan , Aleksander Morgado , Network Development , Sean Tranchetti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi all, Il giorno ven 13 ago 2021 alle ore 08:25 Bj=C3=B8rn Mork ha= scritto: > > subashab@codeaurora.org writes: > > >> Just an heads-up that when I proposed that urb size there were doubts > >> about the value (see > >> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992= -1-dnlplm@gmail.com/#2523774 > >> and > >> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992= -1-dnlplm@gmail.com/#2523958): > >> it is true that this time you are setting the size just when qmap is > >> enabled, but I think that Carl's comment about low-cat chipsets could > >> still apply. > >> Thanks, > >> Daniele > >> > > > > Thanks for bringing this up. > > > > Looks like a tunable would be needed to satisfy all users. > > Perhaps we can use 32k as default in mux and passthrough mode but > > allow for changes > > there if needed through a sysfs. > > Sounds reasonable to me. > I have done a bit of testing both with qmi_wwann qmap implementation and rmnet, so far everything seems to be working fine. Thanks, Daniele > > > Bj=C3=B8rn