netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matteo Croce <mcroce@redhat.com>
To: Marco Oliverio <marco.oliverio@tanaza.com>
Cc: rocco.folino@tanaza.com, netdev <netdev@vger.kernel.org>,
	Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst
Date: Mon, 2 Dec 2019 22:51:35 +0100	[thread overview]
Message-ID: <CAGnkfhzTq2HJ2Pm1sLOLaeOET926SjqRznQLy-CrMue_cpeLRg@mail.gmail.com> (raw)
In-Reply-To: <20191202184259.30416-1-marco.oliverio@tanaza.com>

On Mon, Dec 2, 2019 at 7:43 PM Marco Oliverio <marco.oliverio@tanaza.com> wrote:
>
> Bridge packets that are forwarded have skb->dst == NULL and get
> dropped by the check introduced by
> b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force
> return true when dst is refcounted).
>
> To fix this we check skb_dst() before skb_dst_force(), so we don't
> drop skb packet with dst == NULL. This holds also for skb at the
> PRE_ROUTING hook so we remove the second check.
>
> Fixes: b60a773 ("net: make skb_dst_forcereturn true when dst is refcounted")
>
> Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
> Signed-off-by: Rocco Folino <rocco.folino@tanaza.com>

Tested-by: Matteo Croce <mcroce@redhat.com>

-- 
Matteo Croce
per aspera ad upstream


  reply	other threads:[~2019-12-02 21:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 18:42 [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst Marco Oliverio
2019-12-02 21:51 ` Matteo Croce [this message]
2019-12-02 18:43 Marco Oliverio
2019-12-02 18:45 Marco Oliverio
2019-12-02 18:54 Marco Oliverio
2019-12-02 18:58 ` Florian Westphal
2019-12-02 19:04 ` Marco Oliverio
2019-12-07 18:52 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGnkfhzTq2HJ2Pm1sLOLaeOET926SjqRznQLy-CrMue_cpeLRg@mail.gmail.com \
    --to=mcroce@redhat.com \
    --cc=fw@strlen.de \
    --cc=marco.oliverio@tanaza.com \
    --cc=netdev@vger.kernel.org \
    --cc=rocco.folino@tanaza.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).