From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCAB5C31E5B for ; Tue, 18 Jun 2019 15:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1DE120873 for ; Tue, 18 Jun 2019 15:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729566AbfFRPm0 (ORCPT ); Tue, 18 Jun 2019 11:42:26 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43034 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729189AbfFRPm0 (ORCPT ); Tue, 18 Jun 2019 11:42:26 -0400 Received: by mail-lf1-f68.google.com with SMTP id j29so9647410lfk.10 for ; Tue, 18 Jun 2019 08:42:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bjd5132eo7jNT+3OWPZ+DQKihSgNN8ZcFc+D65z8nSA=; b=Q9mv6pX/yUBjnXWohELYWjTm9BZWbUiU1J0Ux8WLu2+zEaFQeUIkyQt60xNXhAu3cL WOLiiBmAEtwZWP/ZAnd3iK0etr6hgnpBQjDa4OyFg6hsQmVyuBNpnj2N2Tj1e3l8eW1k INfYb6dL4fkKdh6U8tpbHSwk11+UIBAlKGD/MjOPIIUUM2ocIS7azxEbn1PWinXNRzX4 8c1GkZOmSTi05hYg+eVMklV/PTQYsgeise41j/ZHGfJNan4jcXZwVr0hFxO8nkTcY3jH miOIKQP2ZQMehTXetQ8H3qw1iH6VHObbhvhgGxYabXhAO3gzyvQZSnrhL/8GVTBy0Q27 48sw== X-Gm-Message-State: APjAAAUrl2VZ3X4QUjI+AcKUgFPQl3Tg4aQhAE34WWNKGyxXRzWx4Wo8 clhK9OdwNT6Unzd3pmb1NeN+2Sip27pn2yL1BzYRC4qj X-Google-Smtp-Source: APXvYqyRtXm6TJzYcPCTh1DhMLSdjypQsdmkQqnOtPtuuK9lSEWpSKIahiXdp6wqWAtTyjyx4BuvHo+o9ge+LhE5otY= X-Received: by 2002:a19:ed07:: with SMTP id y7mr62176012lfy.56.1560872544098; Tue, 18 Jun 2019 08:42:24 -0700 (PDT) MIME-Version: 1.0 References: <20190618144935.31405-1-mcroce@redhat.com> In-Reply-To: <20190618144935.31405-1-mcroce@redhat.com> From: Matteo Croce Date: Tue, 18 Jun 2019 17:41:48 +0200 Message-ID: Subject: Re: [PATCH iproute2 v2 0/3] refactor the cmd_exec() To: netdev Cc: Stephen Hemminger , David Ahern , Andrea Claudi Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 18, 2019 at 4:49 PM Matteo Croce wrote: > > Refactor the netns and ipvrf code so less steps are needed to exec commands > in a netns or a VRF context. > Also remove some code which became dead. bloat-o-meter shows a tiny saving. > > Matteo Croce (3): > netns: switch netns in the child when executing commands > ip vrf: use hook to change VRF in the child > netns: make netns_{save,restore} static > > include/namespace.h | 2 -- > include/utils.h | 6 ++--- > ip/ip.c | 1 - > ip/ipnetns.c | 61 ++++++++++++++++++++++++++++++++++----------- > ip/ipvrf.c | 12 ++++++--- > lib/exec.c | 7 +++++- > lib/namespace.c | 31 ----------------------- > lib/utils.c | 27 -------------------- > 8 files changed, 63 insertions(+), 84 deletions(-) > > -- > 2.21.0 > Hi all, this should really be the v3, I did an off-by-one. Sorry, -- Matteo Croce per aspera ad upstream