From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH] net: ks8851: Don't use regulator_get_optional() Date: Thu, 29 May 2014 20:54:27 -0500 Message-ID: References: <1401307872-23190-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "David S . Miller" , linux-arm-msm@vger.kernel.org, lkml , Mark Brown , netdev@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" To: Stephen Boyd Return-path: In-Reply-To: <1401307872-23190-1-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, May 28, 2014 at 3:11 PM, Stephen Boyd wrote: > We shouldn't be using regulator_get_optional() here. These > regulators are always present as part of the physical design and > there isn't any way to use an internal regulator or change the > source of the reference voltage via software. Given that the only > users of this driver in the kernel are DT based, this change > should be transparent to them even if they don't specify any > supplies because the regulator framework will insert dummy > supplies as needed. > > Cc: Nishanth Menon > Cc: Mark Brown > Signed-off-by: Stephen Boyd > --- Reviewed-and-Tested-by: Nishanth Menon SDP2430: with next-20140529: before patch: https://github.com/nmenon/kernel-test-logs/blob/next-20140529/omap2plus_defconfig/sdp2430.txt After patch: http://slexy.org/raw/s21sryFhAx Looks good. --- Regards, Nishanth Menon