netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <cwang@twopensource.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dominick Grift <dac.override@gmail.com>, netdev <netdev@vger.kernel.org>
Subject: Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4
Date: Mon, 4 May 2015 15:17:12 -0700	[thread overview]
Message-ID: <CAHA+R7OrtnPuNX+qa_o4MArL2Sc8T9jALp5tyQYFMv4dxUeF7A@mail.gmail.com> (raw)
In-Reply-To: <1430777167.27254.8.camel@edumazet-glaptop2.roam.corp.google.com>

On Mon, May 4, 2015 at 3:06 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Mon, 2015-05-04 at 14:38 -0700, Cong Wang wrote:
>
>> Compile-test only patch is never ready for review, I thought it is too obvious
>> to mention.
>
> Thats not relevant.
>
> Obvious or not, you are not making things easy for reviewers.
>

Why should I make a NOT-ready-for-review patch easy for reviewers?
What's the point here? I don't have the right to choose my patch NOT
to be reviewed? Huh...


> Our time is precious too, even if you believe its a minor detail.
>
> If you don't care for our feedback, send private patches.


Not until it is ready, apparently.


>
> When I hit 'Reply' to your mail, I don't have the patch available at
> hand, and need to copy/paste it.

That is EXACTLY what I want, because it is NOT READY FOR REVIEW.


>
> Surely I am not alone.
>
> Surely you can change the way you provide patches, even if they are in
> RFC state.

If every patch in this mailing list has to be ready, yes.

Otherwise no, sometimes we do need a patch (or a diff if it is a better name)
ONLY for discussion, aka, NOT for review.


>
> If you don't have time, just ignore these bug reports, and do whatever
> you need to, nobody will complain.
>

Apparently you did nothing before I just sent a reply without a patch,
only patch draws your attention for some reason, I _guess_ you only
rush for patches.

  reply	other threads:[~2015-05-04 22:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 17:07 Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4 Josh Boyer
2015-04-23 17:35 ` Sudeep Holla
2015-04-23 22:53 ` Cong Wang
2015-05-04 13:39 ` Dominick Grift
2015-05-04 18:45   ` Cong Wang
2015-05-04 20:27     ` Stephen Hemminger
2015-05-04 21:35       ` Cong Wang
2015-05-11 13:15         ` Dominick Grift
2015-05-11 14:53           ` Eric Dumazet
2015-05-11 17:42             ` Dominick Grift
2015-05-12  0:13             ` poma
2015-05-12  0:37               ` Eric Dumazet
2015-05-12  1:33                 ` poma
2015-05-12 18:27             ` Dominick Grift
2015-05-21 19:22               ` Josh Boyer
2015-05-21 20:06                 ` Eric Dumazet
2015-05-05  2:32       ` Vlad Yasevich
2015-05-04 20:49     ` Eric Dumazet
2015-05-04 21:38       ` Cong Wang
2015-05-04 22:06         ` Eric Dumazet
2015-05-04 22:17           ` Cong Wang [this message]
2015-05-04 22:29             ` Eric Dumazet
2015-05-04 22:44               ` Cong Wang
2015-05-04 23:00                 ` Eric Dumazet
2015-05-04 23:22                   ` David Miller
2015-05-05  8:33     ` Dominick Grift
2015-05-21 20:28 ` [PATCH net] bridge: fix lockdep splat Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHA+R7OrtnPuNX+qa_o4MArL2Sc8T9jALp5tyQYFMv4dxUeF7A@mail.gmail.com \
    --to=cwang@twopensource.com \
    --cc=dac.override@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).